[Merged by Bors] - dynamic scene builder#6227
Closed
mockersf wants to merge 5 commits intobevyengine:mainfrom
Closed
[Merged by Bors] - dynamic scene builder#6227mockersf wants to merge 5 commits intobevyengine:mainfrom
mockersf wants to merge 5 commits intobevyengine:mainfrom
Conversation
mockersf
added
C-Usability
Member
|
I like this approach much better than either of the other linked PRs. It composes better, and provides an excellent foundation. I'm going to close the others in favor of this. |
This was referenced Oct 10, 2022
alice-i-cecile
requested changes
Oct 10, 2022
Member
alice-i-cecile
left a comment
alice-i-cecile
left a comment
There was a problem hiding this comment.
Obligatory doc nits. Once those are fixed up, this has my approval.
alice-i-cecile
approved these changes
Oct 10, 2022
MrGVSV
approved these changes
Oct 10, 2022
Member
MrGVSV
left a comment
MrGVSV
left a comment
There was a problem hiding this comment.
Just a couple nits. Nothing blocking I don't think, though. Looks good!
Co-authored-by: Gino Valente <49806985+MrGVSV@users.noreply.github.com>
alice-i-cecile
added
the
S-Ready-For-Final-Review
Member
|
Giving this a day or two to attract reviews, then merging it unless there are other complaints. |
Member
|
The oven timer's gone off, this things is adequately baked 🥖 bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 12, 2022
# Objective - make it easier to build dynamic scenes ## Solution - add a builder to create a dynamic scene from a world. it can extract an entity or an iterator of entities - alternative to #6013, leaving the "hierarchy iteration" part to #6185 which does it better - alternative to #6004 - using a builder makes it easier to chain several extractions
Contributor
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
ramirezmike
added a commit
to ramirezmike/bevy
that referenced
this pull request
Oct 13, 2022
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 19, 2022
# Objective - make it easier to build dynamic scenes ## Solution - add a builder to create a dynamic scene from a world. it can extract an entity or an iterator of entities - alternative to bevyengine#6013, leaving the "hierarchy iteration" part to bevyengine#6185 which does it better - alternative to bevyengine#6004 - using a builder makes it easier to chain several extractions
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
# Objective - make it easier to build dynamic scenes ## Solution - add a builder to create a dynamic scene from a world. it can extract an entity or an iterator of entities - alternative to bevyengine#6013, leaving the "hierarchy iteration" part to bevyengine#6185 which does it better - alternative to bevyengine#6004 - using a builder makes it easier to chain several extractions
Pietrek14
pushed a commit
to Pietrek14/bevy
that referenced
this pull request
Dec 17, 2022
# Objective - make it easier to build dynamic scenes ## Solution - add a builder to create a dynamic scene from a world. it can extract an entity or an iterator of entities - alternative to bevyengine#6013, leaving the "hierarchy iteration" part to bevyengine#6185 which does it better - alternative to bevyengine#6004 - using a builder makes it easier to chain several extractions
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective - make it easier to build dynamic scenes ## Solution - add a builder to create a dynamic scene from a world. it can extract an entity or an iterator of entities - alternative to bevyengine#6013, leaving the "hierarchy iteration" part to bevyengine#6185 which does it better - alternative to bevyengine#6004 - using a builder makes it easier to chain several extractions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution
Query<&Children>andQuery<&Parent>to iterate over descendants and ancestors #6185 which does it better