[Merged by Bors] - Add iter_entities to World #6228#6242
Closed
ramirezmike wants to merge 2 commits intobevyengine:mainfrom
Closed
[Merged by Bors] - Add iter_entities to World #6228#6242ramirezmike wants to merge 2 commits intobevyengine:mainfrom
ramirezmike wants to merge 2 commits intobevyengine:mainfrom
Conversation
ramirezmike
changed the title
ramirezmike
changed the title
harudagondi
suggested changes
Oct 12, 2022
alice-i-cecile
added
A-ECS
alice-i-cecile
requested changes
Oct 12, 2022
Member
alice-i-cecile
left a comment
alice-i-cecile
left a comment
There was a problem hiding this comment.
Nice and thorough tests :) Once the doc nits and the .copied changes are made I'll be happy to approve this.
Member
|
@ramirezmike once you've made the appropriate changes feel free to resolve the comments :) |
alice-i-cecile
approved these changes
Oct 12, 2022
alice-i-cecile
requested review from
harudagondi and
mockersf
and removed request for
harudagondi
harudagondi
approved these changes
Oct 12, 2022
alice-i-cecile
added
the
S-Ready-For-Final-Review
mockersf
approved these changes
Oct 12, 2022
Member
|
Could you use this new function in the scene code from #6227? |
Member
|
Yep, it would be ideal to clean that code up while we're here. If you don't have time, I'll merge this on Monday and make a new easy. |
Contributor
Author
I rebased and added a commit to update dynamic_scene.rs to use iter_entities. I know the code is pretty much the same and all the tests pass, but I'll admit, I'm not too familiar with the behavior of dynamic_scene. I ran the scene/scene example before and after the changes and compared the output and it was the same. Let me know if you'd like me to do more extensive testing though 👍 |
alice-i-cecile
approved these changes
Oct 13, 2022
Member
alice-i-cecile
left a comment
alice-i-cecile
left a comment
There was a problem hiding this comment.
That refactor looks great; that's exactly what I was hoping to see.
mockersf
approved these changes
Oct 13, 2022
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 17, 2022
# Objective - Add a way to iterate over all entities from &World ## Solution - Added a function `iter_entities` on World which returns an iterator of `Entity` derived from the entities in the `World`'s `archetypes` --- ## Changelog - Added a function `iter_entities` on World, allowing iterating over all entities in contexts where you only have read-only access to the World.
Contributor
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 19, 2022
# Objective - Add a way to iterate over all entities from &World ## Solution - Added a function `iter_entities` on World which returns an iterator of `Entity` derived from the entities in the `World`'s `archetypes` --- ## Changelog - Added a function `iter_entities` on World, allowing iterating over all entities in contexts where you only have read-only access to the World.
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
# Objective - Add a way to iterate over all entities from &World ## Solution - Added a function `iter_entities` on World which returns an iterator of `Entity` derived from the entities in the `World`'s `archetypes` --- ## Changelog - Added a function `iter_entities` on World, allowing iterating over all entities in contexts where you only have read-only access to the World.
Pietrek14
pushed a commit
to Pietrek14/bevy
that referenced
this pull request
Dec 17, 2022
# Objective - Add a way to iterate over all entities from &World ## Solution - Added a function `iter_entities` on World which returns an iterator of `Entity` derived from the entities in the `World`'s `archetypes` --- ## Changelog - Added a function `iter_entities` on World, allowing iterating over all entities in contexts where you only have read-only access to the World.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective - Add a way to iterate over all entities from &World ## Solution - Added a function `iter_entities` on World which returns an iterator of `Entity` derived from the entities in the `World`'s `archetypes` --- ## Changelog - Added a function `iter_entities` on World, allowing iterating over all entities in contexts where you only have read-only access to the World.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution
iter_entitieson World which returns an iterator ofEntityderived from the entities in theWorld'sarchetypesChangelog
iter_entitieson World, allowing iterating over all entities in contexts where you only have read-only access to the World.