[Merged by Bors] - add serialize feature to bevy_transform#6379
Closed
amiani wants to merge 1 commit intobevyengine:mainfrom
Closed
[Merged by Bors] - add serialize feature to bevy_transform#6379amiani wants to merge 1 commit intobevyengine:mainfrom
amiani wants to merge 1 commit intobevyengine:mainfrom
Conversation
alice-i-cecile
approved these changes
Oct 26, 2022
alice-i-cecile
added
C-Usability
alice-i-cecile
requested changes
Oct 26, 2022
Member
There was a problem hiding this comment.
Actually, this feature needs to be enabled under the bevy_internal feature flag that controls serialization support. See https://github.com/bevyengine/bevy/pull/6248/files#diff-b2ad530faa17948b982fc4e56a12e98206873a4ca7b115552df4ad2b299f83f0R48
james7132
requested changes
Oct 26, 2022
amiani
force-pushed
the
serialize-transform
branch
4 times, most recently
from
875272e to
5771cf3
Compare
james7132
requested changes
Oct 27, 2022
amiani
force-pushed
the
serialize-transform
branch
3 times, most recently
from
ec2594f to
1d43590
Compare
Shatur
reviewed
Oct 30, 2022
Shatur
reviewed
Oct 30, 2022
mockersf
reviewed
Oct 30, 2022
mockersf
reviewed
Oct 30, 2022
mockersf
approved these changes
Oct 30, 2022
Member
mockersf
left a comment
mockersf
left a comment
There was a problem hiding this comment.
a few missing newlines, and then LGTM
alice-i-cecile
added
the
S-Ready-For-Final-Review
amiani
force-pushed
the
serialize-transform
branch
from
1d43590 to
76cbcba
Compare
bors bot
pushed a commit
that referenced
this pull request
Oct 31, 2022
# Objective Fixes #6378 `bevy_transform` is missing a feature corresponding to the `serialize` feature on the `bevy` crate. ## Solution Adds a `serialize` feature to `bevy_transform`. Derives `serde::Serialize` and `Deserialize` when feature is enabled.
Contributor
bors
bot
changed the title
bors bot
pushed a commit
that referenced
this pull request
Oct 31, 2022
# Objective `bevy_core` is missing a feature corresponding to the `serialize` feature on the `bevy` crate. Similar to #6378 and #6379 to serialize `Name` easily. ## Solution Add this feature and hand-written serialization for `Name` (to avoid storing `hash` field). --- ## Changelog ### Added * `Serialize` and `Deserialize` derives for `Name` under `serialize` feature.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective Fixes bevyengine#6378 `bevy_transform` is missing a feature corresponding to the `serialize` feature on the `bevy` crate. ## Solution Adds a `serialize` feature to `bevy_transform`. Derives `serde::Serialize` and `Deserialize` when feature is enabled.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective `bevy_core` is missing a feature corresponding to the `serialize` feature on the `bevy` crate. Similar to bevyengine#6378 and bevyengine#6379 to serialize `Name` easily. ## Solution Add this feature and hand-written serialization for `Name` (to avoid storing `hash` field). --- ## Changelog ### Added * `Serialize` and `Deserialize` derives for `Name` under `serialize` feature.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #6378
bevy_transformis missing a feature corresponding to theserializefeature on thebevycrate.Solution
Adds a
serializefeature tobevy_transform.Derives
serde::SerializeandDeserializewhen feature is enabled.