[Merged by Bors] - Add serialize feature to bevy_core#6423
Closed
Shatur wants to merge 1 commit intobevyengine:mainfrom
Closed
[Merged by Bors] - Add serialize feature to bevy_core#6423Shatur wants to merge 1 commit intobevyengine:mainfrom
serialize feature to bevy_core#6423Shatur wants to merge 1 commit intobevyengine:mainfrom
Conversation
Shatur
force-pushed
the
bevy-core-serialize
branch
from
40e6840 to
1b7d521
Compare
mockersf
reviewed
Oct 30, 2022
Shatur
force-pushed
the
bevy-core-serialize
branch
from
1b7d521 to
207f904
Compare
mockersf
approved these changes
Oct 30, 2022
alice-i-cecile
added
S-Ready-For-Final-Review
Contributor
|
Merge conflict. |
Member
|
@Shatur once the merge conflicts are fixed I'll merge. |
Shatur
force-pushed
the
bevy-core-serialize
branch
from
207f904 to
84f7df8
Compare
Contributor
Author
|
@alice-i-cecile fixed! |
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 31, 2022
# Objective `bevy_core` is missing a feature corresponding to the `serialize` feature on the `bevy` crate. Similar to #6378 and #6379 to serialize `Name` easily. ## Solution Add this feature and hand-written serialization for `Name` (to avoid storing `hash` field). --- ## Changelog ### Added * `Serialize` and `Deserialize` derives for `Name` under `serialize` feature.
Contributor
|
Pull request successfully merged into main. Build succeeded:
|
bors
bot
changed the title
serialize feature to bevy_coreserialize feature to bevy_core
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective `bevy_core` is missing a feature corresponding to the `serialize` feature on the `bevy` crate. Similar to bevyengine#6378 and bevyengine#6379 to serialize `Name` easily. ## Solution Add this feature and hand-written serialization for `Name` (to avoid storing `hash` field). --- ## Changelog ### Added * `Serialize` and `Deserialize` derives for `Name` under `serialize` feature.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
bevy_coreis missing a feature corresponding to theserializefeature on thebevycrate. Similar to #6378 and #6379 to serializeNameeasily.Solution
Add this feature and hand-written serialization for
Name(to avoid storinghashfield).Changelog
Added
SerializeandDeserializederives forNameunderserializefeature.