Deprecate add_startup_system/s#7694
Closed
SpecificProtagonist wants to merge 1 commit intobevyengine:mainfrom
Closed
Deprecate add_startup_system/s#7694SpecificProtagonist wants to merge 1 commit intobevyengine:mainfrom
SpecificProtagonist wants to merge 1 commit intobevyengine:mainfrom
Conversation
Member
|
Can you update this to use Also, I agree with deprecating I think that this: app.add_startup_systems((
system_a,
system_b,
system_c,
))Is much more ergonomic than this: app.add_systems(
(
system_a,
system_b,
system_c,
)
.on_startup(),
) |
Member
|
As a heads up, we've been discussing the |
Contributor
|
add_startup_system and add_startup_systems were deprecated in #8079 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Startup systems used to require
add_startup_systemand belonged to special startup stages. This is no longer necessary: They can just be added to theCoreSchedule::Startupinstead (andadd_startup_system/add_startup_systemsare one-liners doing that).Outside of example apps, startup system aren't as useful anyways as using states is more common, so removing their special status makes sense.
Changelog
App::add_startup_system/add_startup_systemsMigration Guide
add_startup_system(my_system)withadd_system_to_schedule(CoreSchedule::Startup, my_system)