[Merged by Bors] - Support system.in_schedule() and system.on_startup()#7790
Closed
joseph-gio wants to merge 41 commits intobevyengine:mainfrom
Closed
[Merged by Bors] - Support system.in_schedule() and system.on_startup()#7790joseph-gio wants to merge 41 commits intobevyengine:mainfrom
system.in_schedule() and system.on_startup()#7790joseph-gio wants to merge 41 commits intobevyengine:mainfrom
Conversation
This reverts commit 9a80674.
Member
Author
|
Alright, I've removed the state extension methods for now. We'll let the design for them cook a little more. I also replaced every usage of I think we should also deprecate |
joseph-gio
changed the title
system.in_schedule() and system.on_enter(state)system.in_schedule() and system.on_startup()
alice-i-cecile
removed
the
X-Needs-SME
alice-i-cecile
approved these changes
Feb 23, 2023
Member
Agreed on both counts. With the state API cut, I've removed the controversial label and feel good about getting this in. |
joseph-gio
added
A-App
Contributor
|
Example |
Member
Author
|
It seems to work fine on my machine. What does it mean when |
Member
Author
|
I think the bot is just slow. |
Member
Author
|
I realized that we probably don't want to expose |
alice-i-cecile
added
the
S-Ready-For-Final-Review
bors bot
pushed a commit
that referenced
this pull request
Feb 24, 2023
# Objective
Support the following syntax for adding systems:
```rust
App::new()
.add_system(setup.on_startup())
.add_systems((
show_menu.in_schedule(OnEnter(GameState::Paused)),
menu_ssytem.in_set(OnUpdate(GameState::Paused)),
hide_menu.in_schedule(OnExit(GameState::Paused)),
))
```
## Solution
Add the traits `IntoSystemAppConfig{s}`, which provide the extension methods necessary for configuring which schedule a system belongs to. These extension methods return `IntoSystemAppConfig{s}`, which `App::add_system{s}` uses to choose which schedule to add systems to.
---
## Changelog
+ Added the extension methods `in_schedule(label)` and `on_startup()` for configuring the schedule a system belongs to.
## Future Work
* Replace all uses of `add_startup_system` in the engine.
* Deprecate this method
Contributor
|
Pull request successfully merged into main. Build succeeded:
|
bors
bot
changed the title
system.in_schedule() and system.on_startup()system.in_schedule() and system.on_startup()
MonaMayrhofer
added a commit
to MonaMayrhofer/iyes_loopless
that referenced
this pull request
Mar 9, 2023
Accomodate for bevyengine/bevy#7790
MonaMayrhofer
added a commit
to MonaMayrhofer/iyes_loopless
that referenced
this pull request
Mar 9, 2023
Accomodate for bevyengine/bevy#7790
ProfLander
pushed a commit
to Lander-Rust/bevy
that referenced
this pull request
Mar 19, 2023
…7790) # Objective Support the following syntax for adding systems: ```rust App::new() .add_system(setup.on_startup()) .add_systems(( show_menu.in_schedule(OnEnter(GameState::Paused)), menu_ssytem.in_set(OnUpdate(GameState::Paused)), hide_menu.in_schedule(OnExit(GameState::Paused)), )) ``` ## Solution Add the traits `IntoSystemAppConfig{s}`, which provide the extension methods necessary for configuring which schedule a system belongs to. These extension methods return `IntoSystemAppConfig{s}`, which `App::add_system{s}` uses to choose which schedule to add systems to. --- ## Changelog + Added the extension methods `in_schedule(label)` and `on_startup()` for configuring the schedule a system belongs to. ## Future Work * Replace all uses of `add_startup_system` in the engine. * Deprecate this method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Support the following syntax for adding systems:
Solution
Add the traits
IntoSystemAppConfig{s}, which provide the extension methods necessary for configuring which schedule a system belongs to. These extension methods returnIntoSystemAppConfig{s}, whichApp::add_system{s}uses to choose which schedule to add systems to.Changelog
in_schedule(label)andon_startup()for configuring the schedule a system belongs to.Future Work
add_startup_systemin the engine.