Add methods for getting and setting individual color channels for all color spaces.#7759
Closed
LiamGallagher737 wants to merge 8 commits intobevyengine:mainfrom
LiamGallagher737:more-color-channel-getters
Closed
Add methods for getting and setting individual color channels for all color spaces.#7759LiamGallagher737 wants to merge 8 commits intobevyengine:mainfrom LiamGallagher737:more-color-channel-getters
LiamGallagher737 wants to merge 8 commits intobevyengine:mainfrom
LiamGallagher737:more-color-channel-getters
Conversation
alice-i-cecile
added
A-Rendering
coreh
approved these changes
Mar 7, 2023
coreh
approved these changes
Mar 7, 2023
hymm
approved these changes
Mar 13, 2023
Member
|
For the docs on all the I so much want to remove that file 🙁 |
Member
Author
I personally think using a crate like palette is the way to go |
mockersf
reviewed
Jun 10, 2023
mockersf
reviewed
Jun 11, 2023
Selene-Amanita
approved these changes
Aug 14, 2023
Selene-Amanita
added
the
S-Ready-For-Final-Review
Member
|
Fixed in #920. Choice was made fairly arbitrarily; feel free to submit follow-up PRs for nits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #7746 except for making them const which is blocked on const float arithmetic.
Solution
Added a bunch more methods for getting and setting individual color channels for every color space.
Changelog
Added
X_YGet the Y value in linear X colorspace.set_X_YSet the Y value in X colorspace.with_X_YReturns this color with Y set to a new value in X colorspace.For all the remaining channels and color spaces.