wgpu: use mailbox instead of fifo for vsync#920
Merged
cart merged 1 commit intobevyengine:masterfrom Nov 26, 2020
Merged
Conversation
Member
Author
|
@bjorn3 I'm curious if this fixes the lag problem for you (in part or in whole). If you find the time (and the motivation) to run another OBS test, let me know! |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has lower latency (for the platforms that support it). It will fall back to Fifo for platforms that don't support it. Hopefully this will resolve the "input lag" problem for most people.
Its worth pointing out that this doesn't actually resolve the lag problem for me on linux/gnome-x11/nvidia gtx 1070/proprietary driver. Its possible that some aspect of that combination doesn't support "mailbox".
With that setup (and a 100fps monitor) i get 3 frames of lag.
If i disable vsync entirely, i get 1 frame of lag.
This resolved the lag problem for @zachreizner, who suggested this change in the first place.