Updated to wgpu 0.16.0, wgpu-hal 0.16.0 and naga 0.12.0 by airingursb · Pull Request #8446 · bevyengine/bevy

airingursb · 2023-04-20T08:27:54Z

Objective

Updated to wgpu 0.16.0 and wgpu-hal 0.16.0

Changelog

Upgrade wgpu to 0.16.0 and wgpu-hal to 0.16.0
Fix the error in native when using a filterable TextureSampleType::Float on a multisample BindingType::Texture. (reject binding type multisampled when on a float filterable sample type gfx-rs/wgpu#3686)

Rollback TextureSampleType::Float filterable setter Fix Error when using a filterable on a multisample

github-actions · 2023-04-20T08:28:05Z

Welcome, new contributor!

Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨

mockersf · 2023-04-20T08:33:12Z

Could you also update naga to 0.12?

You may have to change a few other things for examples to work, don't hesitate to run them all on your computer (bash ./tools/example_showcase.sh). Example shader_prepass is failing for me without additional changes.

airingursb · 2023-04-20T08:45:12Z

Could you also update naga to 0.12?

You may have to change a few other things for examples to work, don't hesitate to run them all on your computer (bash ./tools/example_showcase.sh). Example shader_prepass is failing for me without additional changes.

Okay, I will update naga and then run the examples to verify.

Emmm, but shader_prepass work successful for me without additional changes.

SystemInfo { os: "MacOS 13.3 ", kernel: "22.4.0", cpu: "Intel(R) Core(TM) i7-10700K CPU @ 3.80GHz", core_count: "8", memory: "96.0 GiB" }

JasmineLowen

Hey cool! I was working on the same changes. I don't have any knowledge at all in the specifics of that domain and I was struggling at a few places. Can you maybe clarify a few changes?

Feel free to ignore my comments if they get in the way.

crates/bevy_render/src/texture/fallback_image.rs

crates/bevy_render/src/texture/image.rs

crates/bevy_render/src/texture/ktx2.rs

Azorlogh · 2023-04-20T08:58:38Z

Just a heads up for the changelog, this update also fixes this issue 5732 🙂

BD103 · 2023-04-20T12:58:29Z

Be warned that 0.16.0 is a breaking change, so the release notes will need to include some sort of migration guide for changing keywords like type to alias etc. I know that Bevy isn't against breaking changes, but it still should be mentioned.

tim-blackbird

LGTM. Changes match what's in the wgpu changelog.

github-actions · 2023-04-21T18:15:08Z

It looks like your PR is a breaking change, but you didn't provide a migration guide.

Could you add some context on what users should update when this change get released in a new version of Bevy?
It will be used to help writing the migration guide for the version. Putting it after a ## Migration Guide will help it get automatically picked up by our tooling.

mockersf · 2023-04-21T21:28:46Z

There are some code to fix behind features, and some formatting to update.

JasmineLowen · 2023-04-22T10:12:23Z

FYI, just a small warning:

We found some crashes with the update to wgpu 0.16. It only happens when compiling to wasm, running the app on MacOS and changing the perspective of the camera. It crashes not only the app, but the browser. We tested this on several browsers and it happened everywhere everytime. The App was running normally when compiled for native use. It's most likely some issue with MacOS + the new version of wgpu and isn't caused by bevy directly.

We are still investigating it and are working on a minimal repro example to test if it might be related to that specific machine or if it's really related to MacOS in general.

Update: Apparently it also happens with wgpu 0.15, so this PR here shouldn't be an issue 😅 I'll link to an issue just for documentation purposes once we've filed one.

Update 2: There is an issue for this now, it's #8481

superdump · 2023-04-23T13:33:33Z

Please run with --features zstd,ktx2,dds to catch a couple more errors. And then it needs to be run through cargo fmt. Other than that, if it's working then it looks good to me.

airingursb · 2023-04-24T02:17:36Z

Please run with --features zstd,ktx2,dds to catch a couple more errors. And then it needs to be run through cargo fmt. Other than that, if it's working then it looks good to me.

@superdump I have revised your question over these commits. Please see if there are any other items that need to be modified.

crates/bevy_render/src/texture/fallback_image.rs

crates/bevy_render/src/texture/ktx2.rs

mockersf · 2023-04-24T14:11:29Z

Could you also compile with feature basis-universal? CI is failing on another decribe()

airingursb · 2023-04-25T02:50:29Z

Could you also compile with feature basis-universal? CI is failing on another decribe()

@mockersf Thanks to suggestion, the related CI problem has been fixed. I need your help to take a look at the version of the Cargo.lock file. The check-bans CI failed.

mockersf · 2023-04-25T07:50:29Z

I've looked at the check-bans failures, they can be ignored 👍

crates/bevy_render/src/texture/image.rs

crates/bevy_render/src/texture/ktx2.rs

After bevyengine/bevy#8446

* Update the bevy example to wgpu 0.16 After bevyengine/bevy#8446 * Remove inaccurate README warning

# Objective Since #8446, example `shader_prepass` logs the following error on my mac m1: ``` ERROR bevy_render::render_resource::pipeline_cache: failed to process shader: error: Entry point fragment at Fragment is invalid = Argument 1 varying error = Capability MULTISAMPLED_SHADING is not supported ``` The example display the 3d scene but doesn't change with the preps selected Maybe related to this update in naga: gfx-rs/naga@cc3a8ac ## Solution - Disable MSAA in the example, and check if it's enabled in the shader

Updated to wgpu 0.16.0 and wgpu-hal 0.16.0

9ff4a00

Rollback TextureSampleType::Float filterable setter Fix Error when using a filterable on a multisample

JasmineLowen reviewed Apr 20, 2023

View reviewed changes

crates/bevy_render/src/texture/fallback_image.rs Outdated Show resolved Hide resolved

crates/bevy_render/src/texture/image.rs Outdated Show resolved Hide resolved

crates/bevy_render/src/texture/ktx2.rs Outdated Show resolved Hide resolved

Updated to naga 0.12.0

7dc2d39

airingursb changed the title ~~Updated to wgpu 0.16.0 and wgpu-hal 0.16.0~~ Updated to wgpu 0.16.0, wgpu-hal 0.16.0, naga 0.12.0 Apr 20, 2023

airingursb changed the title ~~Updated to wgpu 0.16.0, wgpu-hal 0.16.0, naga 0.12.0~~ Updated to wgpu 0.16.0, wgpu-hal 0.16.0 and naga 0.12.0 Apr 20, 2023

JMS55 added A-Rendering Drawing game state to the screen C-Dependencies A change to the crates that Bevy depends on labels Apr 20, 2023

tim-blackbird approved these changes Apr 21, 2023

View reviewed changes

james7132 added the M-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide label Apr 21, 2023

alice-i-cecile added this to the 0.11 milestone Apr 22, 2023

airingursb added 2 commits April 24, 2023 09:35

Updated code format with cargo fmt

fad0a77

Handle the error caused by dds during wgpu upgrade

6c59137

mockersf reviewed Apr 24, 2023

View reviewed changes

crates/bevy_render/src/texture/fallback_image.rs Outdated Show resolved Hide resolved

mockersf reviewed Apr 24, 2023

View reviewed changes

crates/bevy_render/src/texture/ktx2.rs Outdated Show resolved Hide resolved

airingursb added 3 commits April 25, 2023 09:37

Updated the code for upgrading wgpu according to the suggestion by CR

626a790

Fix compilation error under basis-universal feature

5cbe08e

Optimize the code according to the CI prompt

bc47618

mockersf reviewed Apr 25, 2023

View reviewed changes

crates/bevy_render/src/texture/image.rs Outdated Show resolved Hide resolved

Replace unwrap_or_default with unwrap in order to meet error in time

639a09a

mockersf approved these changes Apr 25, 2023

View reviewed changes

superdump reviewed Apr 26, 2023

View reviewed changes

crates/bevy_render/src/texture/image.rs Show resolved Hide resolved

crates/bevy_render/src/texture/ktx2.rs Show resolved Hide resolved

superdump approved these changes Apr 26, 2023

View reviewed changes

Merge branch 'main' into wgpu-0.16

ac12120

mockersf added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Apr 26, 2023

mockersf added this pull request to the merge queue Apr 26, 2023

Merged via the queue into bevyengine:main with commit 4d54ce1 Apr 26, 2023

DJMcNab added a commit to DJMcNab/vello that referenced this pull request Apr 26, 2023

Update the bevy example to wgpu 0.16

b51965d

After bevyengine/bevy#8446

DJMcNab mentioned this pull request Apr 26, 2023

Update the bevy example to wgpu 0.16 linebender/vello#313

Merged

Azorlogh mentioned this pull request Apr 26, 2023

WebGL: INVALID_OPERATION drawArrays with repo #5732

Closed

This was referenced Apr 26, 2023

Webgpu support #8336

Merged

shader_prepass example: disable MSAA for maximum compatibility #8504

Merged

jabuwu mentioned this pull request Apr 27, 2023

WebGL: INVALID_OPERATION drawArrays in WASM build jabuwu/bevy_spine#1

Closed

DJMcNab added a commit to linebender/vello that referenced this pull request Apr 27, 2023

Update the bevy example to wgpu 0.16 (#313)

299b47e

* Update the bevy example to wgpu 0.16 After bevyengine/bevy#8446 * Remove inaccurate README warning

Uh oh!

Conversation

airingursb commented Apr 20, 2023

Objective

Changelog

Uh oh!

github-actions bot commented Apr 20, 2023

Uh oh!

mockersf commented Apr 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

airingursb commented Apr 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JasmineLowen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Azorlogh commented Apr 20, 2023

Uh oh!

BD103 commented Apr 20, 2023

Uh oh!

tim-blackbird left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Apr 21, 2023

Uh oh!

mockersf commented Apr 21, 2023

Uh oh!

JasmineLowen commented Apr 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

superdump commented Apr 23, 2023

Uh oh!

airingursb commented Apr 24, 2023

Uh oh!

Uh oh!

Uh oh!

mockersf commented Apr 24, 2023

Uh oh!

airingursb commented Apr 25, 2023

Uh oh!

mockersf commented Apr 25, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

mockersf commented Apr 20, 2023 •

edited

Loading

airingursb commented Apr 20, 2023 •

edited

Loading

JasmineLowen commented Apr 22, 2023 •

edited

Loading