Skip to content

shader_prepass example: disable MSAA for maximum compatibility #8504

Merged
alice-i-cecile merged 1 commit intobevyengine:mainfrom
mockersf:fix-shader-prepass-example
May 29, 2023
Merged

shader_prepass example: disable MSAA for maximum compatibility #8504
alice-i-cecile merged 1 commit intobevyengine:mainfrom
mockersf:fix-shader-prepass-example

Conversation

@mockersf
Copy link
Member

Objective

Since #8446, example shader_prepass logs the following error on my mac m1:

ERROR bevy_render::render_resource::pipeline_cache: failed to process shader:
error: Entry point fragment at Fragment is invalid
 = Argument 1 varying error
 = Capability MULTISAMPLED_SHADING is not supported

The example display the 3d scene but doesn't change with the preps selected

Maybe related to this update in naga: gfx-rs/naga@cc3a8ac

Solution

  • Disable MSAA in the example, and check if it's enabled in the shader

@mockersf mockersf added A-Rendering Drawing game state to the screen C-Examples An addition or correction to our examples labels Apr 26, 2023
Copy link
Contributor

@IceSentry IceSentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A note explaining the ifdef in the shader itself might be nice too, but not necessary

@nicopap nicopap added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label May 29, 2023
@alice-i-cecile alice-i-cecile added this pull request to the merge queue May 29, 2023
Merged via the queue into bevyengine:main with commit 27e1cf9 May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Rendering Drawing game state to the screen C-Examples An addition or correction to our examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants