Merged
Conversation
This PR adds an explicit "Save" button on the task detail screen. I have added this button mostly to scratch my own itch that bothered me for a long time, but later on I found that others also find clicking "Back" button to save non-intuitive and disrupting to the workflow. My main issue is that when adding new task, my eyes start at the top, then follow all fields to the bottom, where I expect some sort of confirmation button. Please see bgregos#174 for the discussion about it.
Owner
|
Thanks for the PR. This should make things more clear for users, so I'm good from a UI perspective. I do have concerns as to what happens to that row on devices with small screens- I'll check on that before merging. |
Owner
|
Looks good, thanks for your contribution! I'll get this released to the stores soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an explicit "Save" button on the task detail screen. I have added this button mostly to scratch my own itch that bothered me for a long time, but later on I found that others also find clicking "Back" button to save non-intuitive and disrupting to the workflow. My main issue is that when adding new task, my eyes start at the top, then follow all fields to the bottom, where I expect some sort of confirmation button.
Please see #174 for the discussion about it.