Conversation
This PR adds an explicit "Save" button on the task detail screen. I have added this button mostly to scratch my own itch that bothered me for a long time, but later on I found that others also find clicking "Back" button to save non-intuitive and disrupting to the workflow. My main issue is that when adding new task, my eyes start at the top, then follow all fields to the bottom, where I expect some sort of confirmation button. Please see bgregos#174 for the discussion about it.
I found having to manually type tags every time tedious. This PR proposes a slight change in the user interface which uses Chip element to provide user with an easy, one-tap selection for any of the existing tags, but also allows them to create new ones if needed.
bgregos
left a comment
bgregos
left a comment
There was a problem hiding this comment.
Thanks for the PR and for the screenshots. This feature makes things a bit less text-entry heavy, always a plus.
I left a couple suggestions around wording.
| binding.detailTags.setText(default_tags) | ||
| viewModel.setTaskTags(default_tags ?: "") | ||
| binding.actionDelete.setText("Discard") | ||
| binding.actionComplete.setText("Log") |
There was a problem hiding this comment.
The "Log" wording feels a bit unclear to me, but I understand there's a use case for immediately completing a new task. Can you think of a better label that makes it clear the task is being immediately marked as complete?
There was a problem hiding this comment.
I was going by the taskwarrior terminology, specifically task log command, although I agree it's probably not immediately clear what it does.
While I cannot think of a better term at the moment, do you think it would make sense to display toast message after the user selects that action saying something like "The task was added and marked complete." ?
btw, I just realised that I accidentally included code for those dynamic labelling changes in this PR following the discussion here - let me know if you want me to move them into separate PR :)
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| android:ems="5" | ||
| android:hint="new tag" |
There was a problem hiding this comment.
This should be capitalized to match the other fields. Also, I think we should make it clear that adding multiple tags with commas is allowed. Maybe "New Tags"? I'm open to suggestions on the wording.
There was a problem hiding this comment.
To be honest, I didn't even think of adding multiple tags in one go as I don't do that often, but that's definitely a great idea! I have changed the label to New tag(s) below.
2 participants
I found having to manually type tags every time tedious. This PR proposes a slight change in the user interface which uses Chip element to provide user with an easy, one-tap selection for any of the existing tags, but also allows them to create new ones if needed.
Pixel 6
Pixel Tablet
Small Phone
This PR includes #177 (which can be closed if that one is to be merged). If I should rebase it on the main instead, please let me know. #177 did not include screenshots for small devices, this one does.