Update disable-element.js to allow for multiple elements to be selected#1639
Closed
imaperson1060 wants to merge 1 commit intobigskysoftware:masterfrom
imaperson1060:patch-1
Closed
Update disable-element.js to allow for multiple elements to be selected#1639imaperson1060 wants to merge 1 commit intobigskysoftware:masterfrom imaperson1060:patch-1
imaperson1060 wants to merge 1 commit intobigskysoftware:masterfrom
imaperson1060:patch-1
Conversation
Allow selection of multiple elements for toggling
alexpetros
reviewed
Jul 30, 2023
Collaborator
alexpetros
left a comment
alexpetros
left a comment
There was a problem hiding this comment.
Could you add a multiple-element test please? Otherwise looks looks good
| } else if (name == "htmx:afterRequest" && targetElement) { | ||
| targetElement.disabled = false; | ||
| } | ||
| targetElements.forEach(targetElement => { |
Collaborator
There was a problem hiding this comment.
We can't use forEach because it's not IE11 compatible.
Collaborator
|
Ah it looks like it broke the existing test too. You can run |
Contributor
Author
I'll make a new PR following the contributing guide (which I may have forgotten to read last time). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow selection of multiple elements for toggling