Skip to content

Allow disable-element extension to disable multiple elements#1650

Merged
1cg merged 3 commits intobigskysoftware:devfrom
imaperson1060:dev
Sep 14, 2023
Merged

Allow disable-element extension to disable multiple elements#1650
1cg merged 3 commits intobigskysoftware:devfrom
imaperson1060:dev

Conversation

@imaperson1060
Copy link
Copy Markdown
Contributor

Allow multiple elements to be selected in the query

Better version of #1639 - this time I actually read the contribution guide

Allow multiple elements to be selected in the query
@imaperson1060
Copy link
Copy Markdown
Contributor Author

For some reason, when I run npm test, the hx-boost attribute fails. It's not like this in the browser and I didn't change anything related to hx-boost.

image
image

@alexpetros alexpetros changed the title Update disable-element extension Allow disable-element extension to disable multiple elements Jul 31, 2023
@alexpetros alexpetros added the enhancement New feature or request label Jul 31, 2023
Copy link
Copy Markdown
Collaborator

@alexpetros alexpetros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR; strict, intuitive enhancement and I can't think of any reason why this would cause a regression.

Comment thread test/ext/disable-element.js Outdated
@alexpetros alexpetros added the ready for review Issues that are ready to be considered for merging label Jul 31, 2023
Comment thread src/ext/disable-element.js Outdated
@1cg 1cg removed the ready for review Issues that are ready to be considered for merging label Aug 1, 2023
@alexpetros alexpetros added the ready for review Issues that are ready to be considered for merging label Aug 27, 2023
@1cg 1cg merged commit 6e93780 into bigskysoftware:dev Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request ready for review Issues that are ready to be considered for merging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants