Skip to content

Introduce PeersIndicator component - An alternative design#128

Closed
hebasto wants to merge 4 commits into
bitcoin-core:mainfrom
hebasto:220603-peers.ALT
Closed

Introduce PeersIndicator component - An alternative design#128
hebasto wants to merge 4 commits into
bitcoin-core:mainfrom
hebasto:220603-peers.ALT

Conversation

@hebasto
Copy link
Copy Markdown
Member

@hebasto hebasto commented Jun 3, 2022

Sorry, couldn't resist :)

Screenshot from 2022-06-04 08-09-54

Additional design feature:

  • blinking if no connection established

Windows
macOS
Android

@hebasto hebasto force-pushed the 220603-peers.ALT branch 3 times, most recently from f0cd0e6 to f00b1ef Compare June 4, 2022 09:11
@hebasto
Copy link
Copy Markdown
Member Author

hebasto commented Jun 4, 2022

Add blinking when no connection established yet.

@hebasto hebasto force-pushed the 220603-peers.ALT branch from f00b1ef to b9cc4c7 Compare June 4, 2022 11:42
Copy link
Copy Markdown
Contributor

@jarolrod jarolrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer #127, but maybe this just needs a designers touch :)

ping: @GBKS @mouxdesign

Copy link
Copy Markdown
Contributor

@shaavan shaavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would agree with @jarolrod here,

Though this design style is synonym with the network strength a device is getting; I don't feel it suits very well according to our overall design system, at least not in the form it currently is.
Nonetheless, it is an interesting design choice, and I would love to hear @GBKS take on this.

@mouxdesign
Copy link
Copy Markdown

@jarolrod I am not able to see the design on #127. However playing around with a network connection image that is very familiar to users might also be an idea. Most of the designs Christoph created are very round and circular, so am trying to keep with the design style here with this idea.
Group 6

@GBKS
Copy link
Copy Markdown
Contributor

GBKS commented Jun 7, 2022

I think it could this style could work as well. Best to judge it in context of the full design, so I mocked it up here real quick (so much for getting my mind off of bitcoin over the vacation).

Block clock bar peers 220607

On a general note, 5 bars (or dots) feels easier to parse than 10 bars (or dots) both visually (have to look more closely to identify the amount of white bars when there are 10) and logically (what is the difference to me as a user between 6 and 7 bars?).

@mouxdesign
Copy link
Copy Markdown

Very much like the indicator idea provided by @GBKS as it fits in very well with the current design elements. Indeed 5 bars to show load time would perhaps indeed show better visually as well as being more accessible with users with visual limitations. Might be interesting to see how Christophs design looks with the bitcoin logo in orange and the loading bars in orange as well. Just an idea!

For the wording itself..I'm just wondering if words like "your connection" or "network connection" may be an idea as well.

@jarolrod
Copy link
Copy Markdown
Contributor

This was closed because design suggestions are not to be made in this repo. To suggest a change to the design, an issue should be opened up here: https://github.com/BitcoinDesign/Bitcoin-Core-App/issues

Discussion on this will be moved to: BitcoinDesign/Bitcoin-Core-App#21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants