Use caret-right icon instead of greater-than text symbol

[jarolrod]

Mainly only relevant in the AboutOptions component for now.

master	pr

[shaavan]

Concept ACK

• I can see the visual difference between master and PR while testing.

Screenshot:

Master	PR

• This PR also solves the issue of the misaligned arrow of the developer options selector.

Suggestion:

• There is one more instance of setting which need to be addressed here. The ">" for the Proxy settings option on the Connection Settings page should be converted to the icon.

[Rspigler]

tACK commit 1c17b77

I can see the change and it is all lined up on my machine. The one missing the change is the Proxy setting under 'Connection Settings' as @shaavan mentions

[jarolrod]

updated from from 1c17b77 to 1dcdac6 (pr144.01 -> pr144.02, diff)

Changes:

• rebased over changes in PR's this PR is based on
• Updated icon sources to use image:// syntax instead of qrc syntax, as the image:// syntax is required for the image provider to work and provide a proper resolution image. Comparison below (top is image:// and below that is qrc:

[jarolrod]

updated from 1dcdac6 to 36bc09d Compare

Changes: give the developer options setting button the correct action, where it will actually open the developer options subpage

[jarolrod]

updated from 36bc09d to f9f6921

changes: updated over changes on master

[hebasto]

Why are the icon.color and background properties are specified for some elements, but not for others?

[shaavan]

Button is a qml type, so we need to specify the icon.color, background value explicitly for each time the Button is used as actionItem, which this PR does.

Whereas, the ExternalLink is a custom-defined component that already employs the respective icon.color, and background value in its definition, so we need not specify that separately when using it.

In src/qml/controls/ExternalLink.qml

            sourceComponent: Button {
                icon.source: root.iconSource
                icon.color: Theme.color.neutral9
                icon.height: root.iconHeight
                icon.width: root.iconWidth
                background: null
                onClicked: Qt.openUrlExternally(link)
            }

[shaavan]

ACK f9f6921

The ExternalLink and Button components replace all the instances of greater-than text symbol and are used appropriately.

I have two ideas to discuss that we can consider incorporating in this PR or in a follow-up.

1. The Button{} is used twice as an actionItem in the current implementation of GUI. There is a chance that we could need to use this Button configuration multiple times as the development progresses. So we can think about extracting this code as a separate component.
2. There is only one instance of usage of ExternalLink{} where the default values for iconWidth, and iconHeight (30, 30) are used. All other usage instances modify these values to (18, 18). Changing the default values in ExternalLink.qml for these properties will save up on redundant code.