Skip to content

Temporary dark mode button#150

Merged
hebasto merged 1 commit into
bitcoin-core:mainfrom
jarolrod:darkmode-temp
Aug 12, 2022
Merged

Temporary dark mode button#150
hebasto merged 1 commit into
bitcoin-core:mainfrom
jarolrod:darkmode-temp

Conversation

@jarolrod
Copy link
Copy Markdown
Contributor

@jarolrod jarolrod commented Aug 11, 2022 •
edited
Loading

A temporary placement for a button that toggles dark mode on and off within the entire UI. Necessary to visually ensure the UI is looking the way that the designers intend. For example, this rebased on top of #149:

current-ui-darkmode

Windows
Intel macOS
Apple Silicon macOS
ARM64 Android

@hebasto
Copy link
Copy Markdown
Member

hebasto commented Aug 11, 2022

Based on #143 for minimum dependencies.

Rebase?

@jarolrod
Copy link
Copy Markdown
Contributor Author

jarolrod commented Aug 11, 2022

updated from bc774bb to c231381 Compare

changes: update over changes on master

hebasto
hebasto approved these changes Aug 12, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK c231381, tested on Ubuntu 22.04.

@hebasto hebasto merged commit 9ba04a8 into bitcoin-core:main Aug 12, 2022
@jarolrod jarolrod deleted the darkmode-temp branch August 21, 2022 19:44
hebasto pushed a commit to hebasto/gui-qml that referenced this pull request Jun 7, 2025
@jarolrod @hebasto
qml: temporary dark mode button
9a59643 
Github-Pull: bitcoin-core#150
Rebased-From: c231381
hebasto pushed a commit to hebasto/gui-qml that referenced this pull request Jun 8, 2025
@jarolrod @hebasto
qml: temporary dark mode button
10cd2dc 
Github-Pull: bitcoin-core#150
Rebased-From: c231381
hebasto pushed a commit to hebasto/gui-qml that referenced this pull request Jun 8, 2025
@jarolrod @hebasto
qml: temporary dark mode button
ef95e84 
Github-Pull: bitcoin-core#150
Rebased-From: c231381
hebasto pushed a commit to hebasto/gui-qml that referenced this pull request Jun 9, 2025
@jarolrod @hebasto
qml: temporary dark mode button
bc8f98f 
Github-Pull: bitcoin-core#150
Rebased-From: c231381
hebasto pushed a commit to hebasto/gui-qml that referenced this pull request Jun 9, 2025
@jarolrod @hebasto
qml: temporary dark mode button
1917840 
Github-Pull: bitcoin-core#150
Rebased-From: c231381
johnny9 pushed a commit to johnny9/bitcoin-core-app that referenced this pull request Jul 4, 2025
@hebasto
Merge bitcoin-core/gui-qml#150: Temporary dark mode button
ca669c6 
b674572 qml: temporary dark mode button (jarolrod)

Pull request description:

  A temporary placement for a button that toggles dark mode on and off within the entire UI. Necessary to visually ensure the UI is looking the way that the designers intend. For example, this rebased on top of #149:

  ![current-ui-darkmode](https://user-images.githubusercontent.com/23396902/184046910-953acfdc-c72c-4f34-956a-a7575e2f7c9e.png)

  [![Windows](https://img.shields.io/badge/OS-Windows-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/win64/insecure_win_gui.zip?branch=pull/150)
  [![Intel macOS](https://img.shields.io/badge/OS-Intel%20macOS-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos/insecure_mac_gui.zip?branch=pull/150)
  [![Apple Silicon macOS](https://img.shields.io/badge/OS-Apple%20Silicon%20macOS-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos_arm64/insecure_mac_arm64_gui.zip?branch=pull/150)
  [![ARM64 Android](https://img.shields.io/badge/OS-Android-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/android/insecure_android_apk.zip?branch=pull/150)

ACKs for top commit:
  hebasto:
    ACK b674572, tested on Ubuntu 22.04.

Tree-SHA512: a8d761801961b8f0e60a09c41504a77c328ea25a0c64f937a9f8609b2741a1cba8428ce0c092ffc704e19b7ec385a4d380e99c719ef62c466fb63b85ae5e4831
tx-signer450 added a commit to tx-signer450/gui-qml that referenced this pull request Oct 20, 2025
@tx-signer450
Merge bitcoin-core/gui-qml#150: Temporary dark mode button
ca5813d 
b6745722d8c81cce31e1a7647170328f7cf35345 qml: temporary dark mode button (jarolrod)

Pull request description:

  A temporary placement for a button that toggles dark mode on and off within the entire UI. Necessary to visually ensure the UI is looking the way that the designers intend. For example, this rebased on top of #149:

  ![current-ui-darkmode](https://user-images.githubusercontent.com/23396902/184046910-953acfdc-c72c-4f34-956a-a7575e2f7c9e.png)

  [![Windows](https://img.shields.io/badge/OS-Windows-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/win64/insecure_win_gui.zip?branch=pull/150)
  [![Intel macOS](https://img.shields.io/badge/OS-Intel%20macOS-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos/insecure_mac_gui.zip?branch=pull/150)
  [![Apple Silicon macOS](https://img.shields.io/badge/OS-Apple%20Silicon%20macOS-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos_arm64/insecure_mac_arm64_gui.zip?branch=pull/150)
  [![ARM64 Android](https://img.shields.io/badge/OS-Android-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/android/insecure_android_apk.zip?branch=pull/150)

ACKs for top commit:
  hebasto:
    ACK b6745722d8c81cce31e1a7647170328f7cf35345, tested on Ubuntu 22.04.

Tree-SHA512: a8d761801961b8f0e60a09c41504a77c328ea25a0c64f937a9f8609b2741a1cba8428ce0c092ffc704e19b7ec385a4d380e99c719ef62c466fb63b85ae5e4831
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hebasto hebasto hebasto approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jarolrod @hebasto