Extend settings component

[jarolrod]

#124 Introduced information.qml which is a mutation of Setting.qml but introduces an additional two loaders and respective properties to handle the scenarios where a setting doesn't use an option switch and needs to instead display a link, display an image, or take input.

The issue, despite large amounts of duplicate code is that, following this design pattern, we will be introducing a new mutation of Settings.qml everytime we have a scenario when there should be something aside from an option switch.

Instead of endless mutations, Settings.qml can just be made extensible by simply introducing a loader which gives it an actionItem. an actionItem is the interact-able element of this setting; that could be an option switch, a url, a text input box, or something completely new.

An example of something new, see the current simplification of the AboutOptions.qml developer settings button:

-    RowLayout {
-        Header {
-            Layout.fillWidth: true
-            center: false
-            header: qsTr("Developer options")
-            headerSize: 18
-            description: qsTr("Only use these if you have development experience")
-            descriptionSize: 15
-            descriptionMargin: 10
-            wrap: false
-            }
-        Loader {
-            Layout.fillWidth: true
-            Layout.preferredWidth: 0
-            Layout.alignment: Qt.AlignRight
-            Layout.rightMargin: 5
-            active: true
-            visible: active
-            sourceComponent: TextButton {
-                text: ">"
-                bold: false
-                rightalign: true
-                onClicked: {
-                    introductions.incrementCurrentIndex()
-                    swipeView.inSubPage = true
-                }
+    Setting {
+        Layout.fillWidth: true
+        header: qsTr("Developer options")
+        description: qsTr("Only use these if you have development experience")
+        actionItem: TextButton {
+            text: ">"
+            bold: false
+            rightalign: true
+            onClicked: {
+                introductions.incrementCurrentIndex()
+                swipeView.inSubPage = true
             }

[shaavan]

Strong Concept ACK

• I agree with this change for all the reasons explained in the description. Especially because this helps remove redundant code while making the Settings.qml scalable.
• The code changes are complete and exhaustive and completely map the functionality with the master.
• While testing this PR on my laptop (Ubuntu 22.04, Qt version 5.15.3), I observed some key differences from the master.

Testing differences:

1. Hovering over links no more shows the edit cursor.

Screenshot:

Master	PR

2. The optionswitch is misaligned from the divider line.

Screenshot:

Master	PR

There is a few more change that needs to be fixed in master as well, which I would suggest adding to this PR. However, these can be taken up in separate PR as well.

1. The button for the Developers option on the About Options page is not right-aligned properly. (Fixed by PR#144)

Screenshot:

Edit: #144 fixes the misaligned Developers option arrow.

[jarolrod]

updated from ac4dbd2 to 0935349 (PR143.01 -> PR143.02, diff)

changes:

• rebase over changes on Introduce ExternalLink control #141
• update one temporary setting with no importance from an ExternalLink to ValueInput to prevent a warning in the terminal when running the gui

[jarolrod]

updated from 0935349 to 3b53ae6 (pr143.02 -> pr143.03, diff)

changes: rebased over changes in #141

[jarolrod]

updated from 3b53ae6 to 69d0778 (pr143.03 -> pr143.04, diff)

changes: rebased over changes in #141

[hebasto]

ACK 69d0778, tested on Ubuntu 22.04.

[hebasto]

@jarolrod

changes: rebased over changes in #141

One more rebase?

[jarolrod]

updated from 69d0778 to d4db4d1 (pr143r.04 -> pr143.05, diff)

Changes: rebased over changes on master

[hebasto]

re-ACK d4db4d1

[jarolrod]

updated from d4db4d1 to ee82e9c Compare

changes: rebase over changes on master

[hebasto]

re-ACK ee82e9c

Edited PR links in the PR description.

[hebasto]

Please remove this link or update it to https://bitcoincore.org/