Introduce ExternalLink control#141
Merged
Merged
Conversation
This was referenced Aug 3, 2022
shaavan
reviewed
Aug 3, 2022
Contributor
shaavan
left a comment
There was a problem hiding this comment.
Concept ACK
Keeping #143 in mind, porting the code related to creating an external link to separate files makes sense for the following reasons:
- This will allows the component to be used separately from the Settings.qml component.
- This will allow link-related code to be easily maintainable and also more intuitive to use compared to the current implementation.
419bd21 to
b700fc6
Compare
Contributor
Author
|
Updated from 419bd21 to b700fc6 (pr141.01 -> pr141.02, diff) changes:
|
b700fc6 to
7d1d977
Compare
Control to handle storing and opening of external links. Can be just text or icon, or combination.
7d1d977 to
aadee41
Compare
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 7, 2025
Control to handle storing and opening of external links. Can be just text or icon, or combination. Github-Pull: bitcoin-core#141 Rebased-From: aadee41
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 8, 2025
Control to handle storing and opening of external links. Can be just text or icon, or combination. Github-Pull: bitcoin-core#141 Rebased-From: aadee41
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 8, 2025
Control to handle storing and opening of external links. Can be just text or icon, or combination. Github-Pull: bitcoin-core#141 Rebased-From: aadee41
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 9, 2025
Control to handle storing and opening of external links. Can be just text or icon, or combination. Github-Pull: bitcoin-core#141 Rebased-From: aadee41
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 9, 2025
Control to handle storing and opening of external links. Can be just text or icon, or combination. Github-Pull: bitcoin-core#141 Rebased-From: aadee41
johnny9
pushed a commit
to johnny9/bitcoin-core-app
that referenced
this pull request
Jul 4, 2025
5cbad13 qml: introduce ExternalLink control (jarolrod) Pull request description: Control to handle storing and opening of external links. Can be just text or icon, or combination. To be tested with #143 [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/win64/insecure_win_gui.zip?branch=pull/141) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos/insecure_mac_gui.zip?branch=pull/141) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos_arm64/insecure_mac_arm64_gui.zip?branch=pull/141) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/android/insecure_android_apk.zip?branch=pull/141) ACKs for top commit: hebasto: ACK 5cbad13, tested on Ubuntu 22.04. Tree-SHA512: 01a1c456607742ac0ec4fe4a575631a9ab6cc6dc263c773ad2673b69534ce0463fcd8915b6fd9f11c32c8e9315fc204e55fec545dfcaddeb6bd337f2a7708ced
tx-signer450
added a commit
to tx-signer450/gui-qml
that referenced
this pull request
Oct 20, 2025
5cbad1336af11a832d0e48e6245ad2cccaf1b841 qml: introduce ExternalLink control (jarolrod) Pull request description: Control to handle storing and opening of external links. Can be just text or icon, or combination. To be tested with #143 [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/win64/insecure_win_gui.zip?branch=pull/141) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos/insecure_mac_gui.zip?branch=pull/141) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos_arm64/insecure_mac_arm64_gui.zip?branch=pull/141) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/android/insecure_android_apk.zip?branch=pull/141) ACKs for top commit: hebasto: ACK 5cbad1336af11a832d0e48e6245ad2cccaf1b841, tested on Ubuntu 22.04. Tree-SHA512: 01a1c456607742ac0ec4fe4a575631a9ab6cc6dc263c773ad2673b69534ce0463fcd8915b6fd9f11c32c8e9315fc204e55fec545dfcaddeb6bd337f2a7708ced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Control to handle storing and opening of external links. Can be just text or icon, or combination. To be tested with #143