Custom Prune OptionButton by jarolrod · Pull Request #245 · bitcoin-core/gui-qml

jarolrod · 2023-02-02T03:31:53Z

Based on #257 to not conflict

This introduces a new OptionButton in StorageOptions that represents a custom prune target option. This is shown only when the user has gone into detailed settings and chosen a custom prune target.

Additionally, this moves the logic of setting the default prune value from SettingsStorage into StorageOptions. It is the easy storage option button shown during onboarding that should set this. With the original logic, when onboarding is not shown because the user has already gone through it, the app will set prune to 2 gb again.

light	dark

jarolrod · 2023-02-04T17:57:39Z

Updated from 7c3f94d to 7b4085d, Compare

Changes: rebased over main

johnny9 · 2023-02-14T05:44:44Z

            description: optionsModel.pruneSizeGB
-            onEditingFinished: optionsModel.pruneSizeGB = parseInt(text)
+            onEditingFinished: {
+                root.customStorage = true


I think custom storage should only be true if the values don't match the other two options.

johnny9

There is an issue with choosing no prune in the detailed settings and the custom option will be selected and it will show that you want to prune with whatever the prune size was.

hebasto · 2023-02-14T06:58:57Z

based on #243

It has been merged. Rebase?

jarolrod · 2023-02-14T11:09:54Z

Updated from 7b4085d to 35e7eb6, compare

changes: rebased over main

jarolrod · 2023-02-14T11:26:30Z

@johnny9 will address

jarolrod · 2023-02-17T07:54:10Z

updated branch from 35e7eb6 to c85e334, compare

changes: rebased to resolve conflicts, still a WIP

jarolrod · 2023-02-22T07:25:33Z

Updated from from c85e334 to a8d8b34, compare

Changes: fixed logic for when a prune OptionButton is checked

hebasto · 2023-02-22T08:26:50Z

Based on #271 ...

#271 has just been merged.

jarolrod · 2023-02-22T08:33:36Z

Updated from a8d8b34 to e3856c0, compare

Changes: rebased over main

Validates that the input for these settings is not less or larger than the allowed values. If so, displays an informational error text.

This allows for a new OptionButton to be shown in StorageOptions when the user has going into detailed settings during onboarding and chosen a custom prune target

jarolrod · 2023-02-28T04:51:44Z

Updated from e3856c0 to 88a38a1, compare

changes: rebased over main and rebased over changes to PR this is based on.

johnny9

ACK 88a38a1

7968ca9 qml: Introduce Storage OptionButton that represents custom prune target (jarolrod) 61b01e3 qml: expose currently loaded detailItem in InformationPage (jarolrod) 9c6a682 qml: move setting of default prune setting into StorageOptions (jarolrod) d05ea90 qml: Validate input for dbcache, threads, and prune target settings (jarolrod) a339e43 qml: Expose minimum and maximum valid dbcache values (Jarol Rodriguez) a895163 qml: Expose minimum and maximum valid Script Verif Threads values (Jarol Rodriguez) 357a9a5 qml: Allow to show an error text below Setting header text (jarolrod) 390db68 qml: Allow to specify subtext color (jarolrod) Pull request description: Based on bitcoin-core/gui-qml#257 to not conflict This introduces a new OptionButton in StorageOptions that represents a custom prune target option. This is shown only when the user has gone into detailed settings and chosen a custom prune target. Additionally, this moves the logic of setting the default prune value from SettingsStorage into StorageOptions. It is the easy storage option button shown during onboarding that should set this. With the original logic, when onboarding is not shown because the user has already gone through it, the app will set prune to 2 gb again. | light | dark | | ----- | ---- | | <img width="752" alt="Screen Shot 2023-02-01 at 10 30 36 PM" src="https://user-images.githubusercontent.com/23396902/216224800-6bda5263-2661-4eed-b550-7cdf94731408.png"> | <img width="752" alt="Screen Shot 2023-02-01 at 10 30 16 PM" src="https://user-images.githubusercontent.com/23396902/216224815-8cdc3f36-6493-4d80-afc8-c4c26ddb2b5c.png"> | [![Windows](https://img.shields.io/badge/OS-Windows-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/win64/insecure_win_gui.zip?branch=pull/245) [![Intel macOS](https://img.shields.io/badge/OS-Intel%20macOS-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos/insecure_mac_gui.zip?branch=pull/245) [![Apple Silicon macOS](https://img.shields.io/badge/OS-Apple%20Silicon%20macOS-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos_arm64/insecure_mac_arm64_gui.zip?branch=pull/245) [![ARM64 Android](https://img.shields.io/badge/OS-Android-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/android/insecure_android_apk.zip?branch=pull/245) ACKs for top commit: johnny9: ACK 7968ca9 Tree-SHA512: 931f79d4950476e74ebd24d5c9389f364e84ef199e4407e225f11792422be7b0acf4c0abd3cf3feb4f0b03d9a6b9c96af947dc6709249bc4857f7c3da66e7b80

7968ca99b4489a0d55203b4e3ed36122dbf89fa9 qml: Introduce Storage OptionButton that represents custom prune target (jarolrod) 61b01e31c4810f8ef62997b3aeb1d717dad333ca qml: expose currently loaded detailItem in InformationPage (jarolrod) 9c6a682325ab2e04f54a74e1ffbd23dbf9152e7e qml: move setting of default prune setting into StorageOptions (jarolrod) d05ea90ae6994da08c911167778a8f487b9ca6ac qml: Validate input for dbcache, threads, and prune target settings (jarolrod) a339e4316193a1c7df017aec73565d4d4d2c29b1 qml: Expose minimum and maximum valid dbcache values (Jarol Rodriguez) a895163aaaaa6290f6387cded39c00980403acef qml: Expose minimum and maximum valid Script Verif Threads values (Jarol Rodriguez) 357a9a569b7551791d4320bffb27cd4d4b3266b0 qml: Allow to show an error text below Setting header text (jarolrod) 390db68fa5f496717f5e542d93ee4dc203c30891 qml: Allow to specify subtext color (jarolrod) Pull request description: Based on bitcoin-core/gui-qml#257 to not conflict This introduces a new OptionButton in StorageOptions that represents a custom prune target option. This is shown only when the user has gone into detailed settings and chosen a custom prune target. Additionally, this moves the logic of setting the default prune value from SettingsStorage into StorageOptions. It is the easy storage option button shown during onboarding that should set this. With the original logic, when onboarding is not shown because the user has already gone through it, the app will set prune to 2 gb again. | light | dark | | ----- | ---- | | <img width="752" alt="Screen Shot 2023-02-01 at 10 30 36 PM" src="https://user-images.githubusercontent.com/23396902/216224800-6bda5263-2661-4eed-b550-7cdf94731408.png"> | <img width="752" alt="Screen Shot 2023-02-01 at 10 30 16 PM" src="https://user-images.githubusercontent.com/23396902/216224815-8cdc3f36-6493-4d80-afc8-c4c26ddb2b5c.png"> | [![Windows](https://img.shields.io/badge/OS-Windows-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/win64/insecure_win_gui.zip?branch=pull/245) [![Intel macOS](https://img.shields.io/badge/OS-Intel%20macOS-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos/insecure_mac_gui.zip?branch=pull/245) [![Apple Silicon macOS](https://img.shields.io/badge/OS-Apple%20Silicon%20macOS-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos_arm64/insecure_mac_arm64_gui.zip?branch=pull/245) [![ARM64 Android](https://img.shields.io/badge/OS-Android-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/android/insecure_android_apk.zip?branch=pull/245) ACKs for top commit: johnny9: ACK 7968ca99b4489a0d55203b4e3ed36122dbf89fa9 Tree-SHA512: 931f79d4950476e74ebd24d5c9389f364e84ef199e4407e225f11792422be7b0acf4c0abd3cf3feb4f0b03d9a6b9c96af947dc6709249bc4857f7c3da66e7b80

jarolrod force-pushed the custom-prune-setting branch from 7c3f94d to 7b4085d Compare February 4, 2023 17:56

jarolrod mentioned this pull request Feb 5, 2023

V1: Meta Issue #248

Closed

johnny9 reviewed Feb 14, 2023

View reviewed changes

hebasto added the Needs rebase label Feb 14, 2023

jarolrod force-pushed the custom-prune-setting branch from 7b4085d to 35e7eb6 Compare February 14, 2023 11:09

jarolrod marked this pull request as draft February 14, 2023 16:46

jarolrod force-pushed the custom-prune-setting branch from 35e7eb6 to c85e334 Compare February 17, 2023 07:53

jarolrod mentioned this pull request Feb 17, 2023

[DO NOT MERGE] Review current state #267

Closed

jarolrod force-pushed the custom-prune-setting branch from c85e334 to a8d8b34 Compare February 22, 2023 07:24

jarolrod marked this pull request as ready for review February 22, 2023 07:26

jarolrod force-pushed the custom-prune-setting branch from a8d8b34 to e3856c0 Compare February 22, 2023 08:33

hebasto removed the Needs rebase label Feb 22, 2023

jarolrod added 8 commits February 27, 2023 22:50

qml: Allow to specify subtext color

195d8c5

qml: Allow to show an error text below Setting header text

6440078

qml: Expose minimum and maximum valid Script Verif Threads values

4eace03

qml: Expose minimum and maximum valid dbcache values

317b1a5

qml: Validate input for dbcache, threads, and prune target settings

524decd

Validates that the input for these settings is not less or larger than the allowed values. If so, displays an informational error text.

qml: move setting of default prune setting into StorageOptions

aacab2e

qml: expose currently loaded detailItem in InformationPage

1b2dde5

qml: Introduce Storage OptionButton that represents custom prune target

88a38a1

This allows for a new OptionButton to be shown in StorageOptions when the user has going into detailed settings during onboarding and chosen a custom prune target

jarolrod force-pushed the custom-prune-setting branch from e3856c0 to 88a38a1 Compare February 28, 2023 04:50

This was referenced Mar 1, 2023

Smart storage values based on assumed chain and chainstate values #278

Merged

[DO NOT MERGE] Testing recent changes #279

Closed

johnny9 approved these changes Mar 3, 2023

View reviewed changes

hebasto merged commit aae358f into bitcoin-core:main Mar 6, 2023

hebasto mentioned this pull request Mar 6, 2023

Display an error text when ValueInput has invalid user input #257

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Custom Prune OptionButton#245

Custom Prune OptionButton#245
hebasto merged 8 commits into
bitcoin-core:mainfrom
jarolrod:custom-prune-setting

jarolrod commented Feb 2, 2023 •

edited

Loading

Uh oh!

jarolrod commented Feb 4, 2023

Uh oh!

johnny9 Feb 14, 2023

Uh oh!

johnny9 left a comment •

edited

Loading

Uh oh!

hebasto commented Feb 14, 2023

Uh oh!

jarolrod commented Feb 14, 2023

Uh oh!

jarolrod commented Feb 14, 2023

Uh oh!

jarolrod commented Feb 17, 2023

Uh oh!

jarolrod commented Feb 22, 2023

Uh oh!

hebasto commented Feb 22, 2023

Uh oh!

jarolrod commented Feb 22, 2023

Uh oh!

jarolrod commented Feb 28, 2023

Uh oh!

johnny9 left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

jarolrod commented Feb 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jarolrod commented Feb 4, 2023

Uh oh!

johnny9 Feb 14, 2023

Choose a reason for hiding this comment

Uh oh!

johnny9 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hebasto commented Feb 14, 2023

Uh oh!

jarolrod commented Feb 14, 2023

Uh oh!

jarolrod commented Feb 14, 2023

Uh oh!

jarolrod commented Feb 17, 2023

Uh oh!

jarolrod commented Feb 22, 2023

Uh oh!

hebasto commented Feb 22, 2023

Uh oh!

jarolrod commented Feb 22, 2023

Uh oh!

jarolrod commented Feb 28, 2023

Uh oh!

johnny9 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jarolrod commented Feb 2, 2023 •

edited

Loading

johnny9 left a comment •

edited

Loading