Remove redundant MouseAreas from controls that are Buttons

[jarolrod]

For controls that are buttons, an additional MouseArea layer is unnecessary as they already have built-in event detection for actions such as pressing and hovering. By eliminating the redundant MouseAreas in the ContinueButton, NavButton, OutlineButton, Setting, and TextButton controls, we make their implementations cleaner. Previously, the MouseArea was utilized to set the controls' state, but now this is achieved through when statements that are bundled with the states themselves.

[jarolrod]

Updated from 5fa9522 to b30fefd, compare

Changes: updated to fix linter

[johnny9]

hoverEnabled: true needs to be set on the buttons for hover to work.

https://doc.qt.io/qt-5/qml-qtquick-controls2-control.html#hoverEnabled-prop

[johnny9]

States can be simplified a bit to:

       states: [                                                                                                                                                                                                     
            State {                                                                                                                                                                                                   
                name: "PRESSED"; when: root.pressed                                                                                                                                                                   
                PropertyChanges { target: bg; color: Theme.color.orangeLight2 }                                                                                                                                       
            },                                                                                                                                                                                                        
            State {                                                                                                                                                                                                   
                name: "HOVER"; when: root.hovered                                                                                                                                                                     
                PropertyChanges { target: bg; color: Theme.color.orangeLight1 }                                                                                                                                       
            },                                                                                                                                                                                                        
            State {                                                                                                                                                                                                   
                name: "DEFAULT";                                                                                                                                                                                      
                PropertyChanges { target: bg; color: Theme.color.orange }                                                                                                                                             
            }                                                                                                                                                                                                         
        ]               

when can be thought of like a string of "if-else" statements, order matters

This is just optional, though, being explicit has its benefits in terms of readability

[jarolrod]

Updated from b30fefd to b86f893, compare

Changes:

• Simplify when states are triggered per review feedback
• Removed the "DEFAULT" state as this isn't triggered without a specific condition. When components are not on a state they go back to the definitions given when the component was created, so the "DEFAULT" case is now just what where the definitions on creation.
• Reverted the changes to NavButton as that control does need the MouseArea to achieve proper animation of the pressed state

Then updated from b86f893 to f68fd69, compare

Changes:

• Specified hoverEnabled: true per review feedback
• Removed an unnecessary extra condition from the Setting control "HOVER" state

[jarolrod]

Updated from f68fd69 to 80392a5, compare

Changes:

• reversed changes to Setting control because it needs a custom mouseArea for the same reasons that NavButton needs it
• Ensure that Setting and NavButton are explicit with hoverEnabled: true

[johnny9]

ACK 80392a5