ValueInput "EMPTY" state by jarolrod · Pull Request #256 · bitcoin-core/gui-qml

jarolrod · 2023-02-11T00:33:22Z

This adds an "EMPTY" state to ValueInput, as specified in the design file.

This state is only added to ValueInput because the Setting control should not care about this. All other states continue to function as normal*.

Light

EMPTY	FILLED	HOVER	ACTIVE

Dark

EMPTY	FILLED	HOVER	ACTIVE

*the Setting control loses the active state when the mouse moves away from it, will be addressed in a follow-up.

jarolrod · 2023-02-14T11:28:11Z

Updated from e7a6997 to 26aa64c, compare

changes: rebased over main and resolved conflicts

hebasto · 2023-02-16T10:35:10Z

Based on #255

It has just been merged. Rebase?

jarolrod · 2023-02-16T17:33:52Z

Updated from 26aa64c to 85d4cf0, compare

changes: rebased over main

jarolrod · 2023-02-22T03:18:08Z

Updated from 85d4cf0 to 1a7c3ce, compare

Changes:

now based on Remove redundant MouseAreas from controls that are Buttons #271 to not conflict
Removed an explicit "EMPTY" state in favor of a check on filled and feeding back either the "EMPTY" or "FILLED" colors and in the case of "HOVER", the "EMPTY" or "HOVER" colors.

hebasto · 2023-02-22T08:26:14Z

based on #271

#271 has just been merged.

The EMPTY state indicates that this setting hasn't been touched. Clicking on the Setting that contains the ValueInput is enough to put it in the FILLED state.

jarolrod · 2023-02-22T08:28:21Z

Updated from 1a7c3ce to 003f174, compare

Changes: rebased over main

GBKS · 2023-02-27T07:52:01Z

ACK 003f174

07c62ee qml: add EMPTY state to ValueInput (jarolrod) Pull request description: This adds an `"EMPTY"` state to `ValueInput`, as specified in the [design file](https://www.figma.com/file/ek8w3n3upbluw5UL2lGhRx/Bitcoin-Core-App-Design?node-id=6079%3A166395&t=zvbm4HW9rxQf4iBb-4). This state is only added to `ValueInput` because the `Setting` control should not care about this. All other states continue to function as normal*. ### Light | EMPTY | FILLED | HOVER | ACTIVE | | ----- | ------ | ----- | ------ | | <img width="463" alt="Screen Shot 2023-02-10 at 5 26 04 PM" src="https://user-images.githubusercontent.com/23396902/218226249-e1ce6012-33d5-4362-bd1e-7620bbe9ed85.png"> | <img width="463" alt="Screen Shot 2023-02-10 at 5 24 42 PM" src="https://user-images.githubusercontent.com/23396902/218226265-94b2d5ae-fb7e-41b1-a477-3e9cdc7f9b95.png"> | <img width="463" alt="Screen Shot 2023-02-10 at 5 24 57 PM" src="https://user-images.githubusercontent.com/23396902/218226276-c3fbd0a4-08fc-4302-afe6-c3b187cb4095.png"> | <img width="463" alt="Screen Shot 2023-02-10 at 5 25 18 PM" src="https://user-images.githubusercontent.com/23396902/218226286-4cd43650-9121-4899-9bab-4d844e1efb03.png"> | ### Dark | EMPTY | FILLED | HOVER | ACTIVE | | ----- | ------ | ----- | ------ | | <img width="463" alt="Screen Shot 2023-02-10 at 5 23 43 PM" src="https://user-images.githubusercontent.com/23396902/218226406-9be869ee-0eb1-412c-b5ed-426d35ca9341.png"> | <img width="463" alt="Screen Shot 2023-02-10 at 5 24 00 PM" src="https://user-images.githubusercontent.com/23396902/218226415-59b2c42d-80e4-4a6d-a7dc-631a7f195ce9.png"> | <img width="463" alt="Screen Shot 2023-02-10 at 5 24 11 PM" src="https://user-images.githubusercontent.com/23396902/218226432-34b6cc5f-e0d0-48e1-af11-a2e59d0bd0e5.png"> | <img width="463" alt="Screen Shot 2023-02-10 at 5 24 28 PM" src="https://user-images.githubusercontent.com/23396902/218226448-d0c801a8-c232-449a-82e7-282108e9e44a.png"> | *the Setting control loses the active state when the mouse moves away from it, will be addressed in a follow-up. [![Windows](https://img.shields.io/badge/OS-Windows-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/win64/insecure_win_gui.zip?branch=pull/256) [![Intel macOS](https://img.shields.io/badge/OS-Intel%20macOS-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos/insecure_mac_gui.zip?branch=pull/256) [![Apple Silicon macOS](https://img.shields.io/badge/OS-Apple%20Silicon%20macOS-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos_arm64/insecure_mac_arm64_gui.zip?branch=pull/256) [![ARM64 Android](https://img.shields.io/badge/OS-Android-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/android/insecure_android_apk.zip?branch=pull/256) ACKs for top commit: GBKS: ACK 07c62ee Tree-SHA512: bc6584cbf75e36ac6b4e944822756861159d6a5b355342e91e915c3c69562fd7b819a68dbe28904bf9fbacf825c57858386cc7b83680844e0625f0fdd304bee6

07c62ee06b208ffe6abcdc18d9997d6fa0e1a7c4 qml: add EMPTY state to ValueInput (jarolrod) Pull request description: This adds an `"EMPTY"` state to `ValueInput`, as specified in the [design file](https://www.figma.com/file/ek8w3n3upbluw5UL2lGhRx/Bitcoin-Core-App-Design?node-id=6079%3A166395&t=zvbm4HW9rxQf4iBb-4). This state is only added to `ValueInput` because the `Setting` control should not care about this. All other states continue to function as normal*. ### Light | EMPTY | FILLED | HOVER | ACTIVE | | ----- | ------ | ----- | ------ | | <img width="463" alt="Screen Shot 2023-02-10 at 5 26 04 PM" src="https://user-images.githubusercontent.com/23396902/218226249-e1ce6012-33d5-4362-bd1e-7620bbe9ed85.png"> | <img width="463" alt="Screen Shot 2023-02-10 at 5 24 42 PM" src="https://user-images.githubusercontent.com/23396902/218226265-94b2d5ae-fb7e-41b1-a477-3e9cdc7f9b95.png"> | <img width="463" alt="Screen Shot 2023-02-10 at 5 24 57 PM" src="https://user-images.githubusercontent.com/23396902/218226276-c3fbd0a4-08fc-4302-afe6-c3b187cb4095.png"> | <img width="463" alt="Screen Shot 2023-02-10 at 5 25 18 PM" src="https://user-images.githubusercontent.com/23396902/218226286-4cd43650-9121-4899-9bab-4d844e1efb03.png"> | ### Dark | EMPTY | FILLED | HOVER | ACTIVE | | ----- | ------ | ----- | ------ | | <img width="463" alt="Screen Shot 2023-02-10 at 5 23 43 PM" src="https://user-images.githubusercontent.com/23396902/218226406-9be869ee-0eb1-412c-b5ed-426d35ca9341.png"> | <img width="463" alt="Screen Shot 2023-02-10 at 5 24 00 PM" src="https://user-images.githubusercontent.com/23396902/218226415-59b2c42d-80e4-4a6d-a7dc-631a7f195ce9.png"> | <img width="463" alt="Screen Shot 2023-02-10 at 5 24 11 PM" src="https://user-images.githubusercontent.com/23396902/218226432-34b6cc5f-e0d0-48e1-af11-a2e59d0bd0e5.png"> | <img width="463" alt="Screen Shot 2023-02-10 at 5 24 28 PM" src="https://user-images.githubusercontent.com/23396902/218226448-d0c801a8-c232-449a-82e7-282108e9e44a.png"> | *the Setting control loses the active state when the mouse moves away from it, will be addressed in a follow-up. [![Windows](https://img.shields.io/badge/OS-Windows-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/win64/insecure_win_gui.zip?branch=pull/256) [![Intel macOS](https://img.shields.io/badge/OS-Intel%20macOS-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos/insecure_mac_gui.zip?branch=pull/256) [![Apple Silicon macOS](https://img.shields.io/badge/OS-Apple%20Silicon%20macOS-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos_arm64/insecure_mac_arm64_gui.zip?branch=pull/256) [![ARM64 Android](https://img.shields.io/badge/OS-Android-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/android/insecure_android_apk.zip?branch=pull/256) ACKs for top commit: GBKS: ACK 07c62ee06b208ffe6abcdc18d9997d6fa0e1a7c4 Tree-SHA512: bc6584cbf75e36ac6b4e944822756861159d6a5b355342e91e915c3c69562fd7b819a68dbe28904bf9fbacf825c57858386cc7b83680844e0625f0fdd304bee6

jarolrod changed the title ~~ValueInput EMPTY~~ ValueInput "EMPTY" state Feb 11, 2023

This was referenced Feb 11, 2023

Introduce List Item Settings states in accordance to the design file #230

Closed

Display an error text when ValueInput has invalid user input #257

Merged

hebasto added the Needs rebase label Feb 14, 2023

jarolrod force-pushed the valinput-empty-state branch from e7a6997 to 26aa64c Compare February 14, 2023 11:27

hebasto removed the Needs rebase label Feb 15, 2023

hebasto added the Needs rebase label Feb 16, 2023

jarolrod force-pushed the valinput-empty-state branch from 26aa64c to 85d4cf0 Compare February 16, 2023 17:32

jarolrod mentioned this pull request Feb 17, 2023

[DO NOT MERGE] Review current state #267

Closed

hebasto removed the Needs rebase label Feb 17, 2023

jarolrod force-pushed the valinput-empty-state branch from 85d4cf0 to 1a7c3ce Compare February 22, 2023 03:15

jarolrod mentioned this pull request Feb 22, 2023

Custom Prune OptionButton #245

Merged

hebasto added the Needs rebase label Feb 22, 2023

qml: add EMPTY state to ValueInput

003f174

The EMPTY state indicates that this setting hasn't been touched. Clicking on the Setting that contains the ValueInput is enough to put it in the FILLED state.

jarolrod force-pushed the valinput-empty-state branch from 1a7c3ce to 003f174 Compare February 22, 2023 08:27

hebasto merged commit 655365b into bitcoin-core:main Feb 27, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ValueInput "EMPTY" state#256

ValueInput "EMPTY" state#256
hebasto merged 1 commit into
bitcoin-core:mainfrom
jarolrod:valinput-empty-state

jarolrod commented Feb 11, 2023 •

edited

Loading

Uh oh!

jarolrod commented Feb 14, 2023

Uh oh!

hebasto commented Feb 16, 2023

Uh oh!

jarolrod commented Feb 16, 2023

Uh oh!

jarolrod commented Feb 22, 2023

Uh oh!

hebasto commented Feb 22, 2023

Uh oh!

jarolrod commented Feb 22, 2023

Uh oh!

GBKS commented Feb 27, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

jarolrod commented Feb 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Light

Dark

Uh oh!

jarolrod commented Feb 14, 2023

Uh oh!

hebasto commented Feb 16, 2023

Uh oh!

jarolrod commented Feb 16, 2023

Uh oh!

jarolrod commented Feb 22, 2023

Uh oh!

hebasto commented Feb 22, 2023

Uh oh!

jarolrod commented Feb 22, 2023

Uh oh!

GBKS commented Feb 27, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jarolrod commented Feb 11, 2023 •

edited

Loading