Add Connecting Animation with "Grow" Animation#280
Merged
Conversation
Collaborator
Author
|
From connecting to syncing: From connecting to blocks: |
johnny9
force-pushed
the
connection-animation-grow
branch
from
30049ba to
14c8e1c
Compare
johnny9
force-pushed
the
connection-animation-grow
branch
from
14c8e1c to
31d506f
Compare
Collaborator
Author
|
Update to 31d506f:
|
Collaborator
Author
|
Signet sync with easing: |
jarolrod
reviewed
Mar 13, 2023
| this, [=]() { | ||
| if (m_is_connected | ||
| && getTargetAnimationAngle() - m_animating_max_angle < 1) { | ||
| m_animation_timer.stop(); |
Contributor
There was a problem hiding this comment.
The connecting animation seems to only be playing once and then won't play again on subsequent scenarios where we are trying to connect. I think because there's nothing starting this timer again?
Collaborator
Author
There was a problem hiding this comment.
Yeah that's likely correct. Ill have another look at the stopping condition here.
Contributor
There was a problem hiding this comment.
NVM not seeing this issue any more, am on plane wifi, maybe it was acting up somehow
jarolrod
approved these changes
Mar 13, 2023
johnny9
pushed a commit
to johnny9/bitcoin-core-app
that referenced
this pull request
Jul 4, 2025
…Animation ec7b96b qml: add easing to BlockClockDial grow animations (johnny9) b8075f2 qml: add "grow" animation to the blockclockdial (johnny9) 97e1921 qml: Add timer to control BlockClockDial connecting animation (johnny9) 564e45e qml: Add connection animation to block clock (jarolrod) Pull request description: [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/win64/insecure_win_gui.zip?branch=pull/280) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos/insecure_mac_gui.zip?branch=pull/280) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos_arm64/insecure_mac_arm64_gui.zip?branch=pull/280) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/android/insecure_android_apk.zip?branch=pull/280) ACKs for top commit: jarolrod: ACK ec7b96b Tree-SHA512: bc8fc53d09a684e2d56fd15b347a88aee048ae5c5578c36e51fc0d40a9f5efb5e5c3014ac52f77c8408ac897520d2d3832aad53451246a2fbccdf16b97a045d6
tx-signer450
added a commit
to tx-signer450/gui-qml
that referenced
this pull request
Oct 20, 2025
…Animation ec7b96bd26ae8031b936ea9400afd7e65b5c9ef4 qml: add easing to BlockClockDial grow animations (johnny9) b8075f2dffa0183c66f747e31ee34f93fe38bd75 qml: add "grow" animation to the blockclockdial (johnny9) 97e1921896e28456cc446f072fd1c3cb6b15590b qml: Add timer to control BlockClockDial connecting animation (johnny9) 564e45eb496f809d0935af5a09634462307e443d qml: Add connection animation to block clock (jarolrod) Pull request description: [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/win64/insecure_win_gui.zip?branch=pull/280) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos/insecure_mac_gui.zip?branch=pull/280) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos_arm64/insecure_mac_arm64_gui.zip?branch=pull/280) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/android/insecure_android_apk.zip?branch=pull/280) ACKs for top commit: jarolrod: ACK ec7b96bd26ae8031b936ea9400afd7e65b5c9ef4 Tree-SHA512: bc8fc53d09a684e2d56fd15b347a88aee048ae5c5578c36e51fc0d40a9f5efb5e5c3014ac52f77c8408ac897520d2d3832aad53451246a2fbccdf16b97a045d6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.