Add Connection animation with delay timers#272
Closed
johnny9 wants to merge 2 commits into
Closed
Conversation
jarolrod
reviewed
Feb 22, 2023
jarolrod
reviewed
Mar 1, 2023
| m_connecting_start_angle = decrementGradientAngle(m_connecting_start_angle); | ||
| } | ||
|
|
||
| void BlockClockDial::paintBackground(QPainter * painter) |
Contributor
There was a problem hiding this comment.
one thing we can lump in here, since this is introducing the idea of connected into this component, is some logic to only draw the background when connecting. Right now the dial can draw blocks or some of the progress while it is connected.
diff --git a/src/qml/components/blockclockdial.cpp b/src/qml/components/blockclockdial.cpp
index 07f2af85d..63e83ff4d 100644
--- a/src/qml/components/blockclockdial.cpp
+++ b/src/qml/components/blockclockdial.cpp
@@ -252,9 +252,9 @@ void BlockClockDial::paint(QPainter * painter)
return;
}
- if (synced()) {
+ if (synced() && connected()) {
paintBlocks(painter);
- } else {
+ } else if (!synced() && connected()) {
paintProgress(painter);
}
}
Contributor
There was a problem hiding this comment.
This is what I'm referring to on current master
| connecting | syncing |
|---|---|
 |
 |
johnny9
force-pushed
the
connection-animation
branch
2 times, most recently
from
34170ae to
140e2de
Compare
Collaborator
Author
|
Going with the "Grow" animation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An extension of #261 with a 5 second delay and limited to 60fps