Skip to content

Add Connection animation to Block Clock connecting state#261

Closed
jarolrod wants to merge 1 commit into
bitcoin-core:mainfrom
jarolrod:connection-animation
Closed

Add Connection animation to Block Clock connecting state#261
jarolrod wants to merge 1 commit into
bitcoin-core:mainfrom
jarolrod:connection-animation

Conversation

@jarolrod
Copy link
Copy Markdown
Contributor

@jarolrod jarolrod commented Feb 13, 2023

light dark
animation-light dark-animation

Windows
Intel macOS
Apple Silicon macOS
ARM64 Android

@jarolrod jarolrod force-pushed the connection-animation branch 2 times, most recently from aeefcd9 to e2ecfaf Compare February 13, 2023 09:01
@GBKS
Copy link
Copy Markdown
Contributor

GBKS commented Feb 13, 2023

Thank you for implementing this, I just tested it and have a few thoughts.

Since we have the blinking dots to communicate that a network connection is being established, I don't think we need to show this massive loader right away. Maybe it can only appear after 5 seconds of a blink dot, in case the user gets impatient ("now the app is trying really hard").

Fading the loader in and out somewhat slowly, maybe 600ms, would be nice to avoid this abrupt effect we have right now where it pops in/out instantly.

It looks like the gradient currently goes from yellow to red to the background color. Is it possible to add transparency to this? There's a very slightly funky effect happening right now where the dots on the dial behind the loader get covered up by the last part of the gradient that uses the background color. This could be done later, not sure if anyone really notices this.

Overall, is there any other type of loading the app does that might also need a loader?

On a sidenote, I tested this by disabling wi-fi altogether. Would be awesome if there's a way to detect whether the phone has any type of internet connection and show an appropriate message.

@jarolrod really appreciate how much work you're putting into this app. Hats off to you.

@hebasto
Copy link
Copy Markdown
Member

hebasto commented Feb 14, 2023

Based on #252

It has been merged.

@jarolrod jarolrod force-pushed the connection-animation branch from e2ecfaf to 6d97c0a Compare February 16, 2023 18:17
@jarolrod
Copy link
Copy Markdown
Contributor Author

Updated from e2ecfaf to 6d97c0a, compare

Changes: rebased over main

@jarolrod jarolrod force-pushed the connection-animation branch from 6d97c0a to 3d4a760 Compare February 22, 2023 00:11
@jarolrod
Copy link
Copy Markdown
Contributor Author

Updated from 6d97c0a to 3d4a760, compare

Changes: made last color in gradient transparent instead of Theme.color.background

master pr
animation-light Screen Recording 2023-02-21 at 6 55 37 PM
dark-animation pr-dark

@jarolrod
Copy link
Copy Markdown
Contributor Author

Closing in favor of #272

@jarolrod jarolrod closed this Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants