Blockclock connecting state#252
Merged
Merged
Conversation
Member
It has been just merged. Rebase? |
jarolrod
force-pushed
the
blockclock-connecting-state
branch
from
da46d4e to
0411eec
Compare
Contributor
Author
Contributor
Author
|
Missing the connecting spinning animation on the dial, someone can pick that up later |
Member
|
Once more rebase? |
jarolrod
force-pushed
the
blockclock-connecting-state
branch
from
0411eec to
e3e7b4c
Compare
Contributor
Author
This was referenced Feb 11, 2023
Closed
johnny9
approved these changes
Feb 14, 2023
johnny9
pushed a commit
to johnny9/bitcoin-core-app
that referenced
this pull request
Jul 4, 2025
4a78e78 qml: wire up logic for block clock connecting state (jarolrod) Pull request description: Wires logic so that the connecting state for the block clock will actually show when the node is finding peers <img width="400" alt="Screen Shot 2023-02-08 at 11 52 38 PM" src="https://user-images.githubusercontent.com/23396902/217739279-4f4d85e0-38e9-4139-ada7-4f9e72acc5df.png"> [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/win64/insecure_win_gui.zip?branch=pull/252) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos/insecure_mac_gui.zip?branch=pull/252) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos_arm64/insecure_mac_arm64_gui.zip?branch=pull/252) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/android/insecure_android_apk.zip?branch=pull/252) ACKs for top commit: johnny9: ACK 4a78e78 Tree-SHA512: 1243670cfd410b0a56d7677aaf8bb2a2a17e89846c1bfba7ced6222987e38bba509c3b4be767b3e74378178c1e868f80b66642fbd4e64d135a62ebe152677d60
tx-signer450
added a commit
to tx-signer450/gui-qml
that referenced
this pull request
Oct 20, 2025
4a78e78f73dc6f9fc6b6a99ee1a86cca32461d30 qml: wire up logic for block clock connecting state (jarolrod) Pull request description: Wires logic so that the connecting state for the block clock will actually show when the node is finding peers <img width="400" alt="Screen Shot 2023-02-08 at 11 52 38 PM" src="https://user-images.githubusercontent.com/23396902/217739279-4f4d85e0-38e9-4139-ada7-4f9e72acc5df.png"> [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/win64/insecure_win_gui.zip?branch=pull/252) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos/insecure_mac_gui.zip?branch=pull/252) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos_arm64/insecure_mac_arm64_gui.zip?branch=pull/252) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/android/insecure_android_apk.zip?branch=pull/252) ACKs for top commit: johnny9: ACK 4a78e78f73dc6f9fc6b6a99ee1a86cca32461d30 Tree-SHA512: 1243670cfd410b0a56d7677aaf8bb2a2a17e89846c1bfba7ced6222987e38bba509c3b4be767b3e74378178c1e868f80b66642fbd4e64d135a62ebe152677d60
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wires logic so that the connecting state for the block clock will actually show when the node is finding peers