Introduce PeersIndicator component, Add to BlockClock#236
Merged
Conversation
Co-authored-by: Christoph Ono <chri@sto.ph>
This was referenced Feb 1, 2023
Closed
johnny9
pushed a commit
to johnny9/bitcoin-core-app
that referenced
this pull request
Jul 4, 2025
…dd to BlockClock fc34996 qml: add PeersIndicator to BlockClock (jarolrod) 5d0ea0e qml: Add `PeersIndicator` component (Hennadii Stepanov) f5c2cd0 qml: Add `NodeModel::numOutboundPeers` property (Hennadii Stepanov) 475c63ef4752f7b79eca647072208f3a5be8d56e net: Notify about connection number by type (Hennadii Stepanov) Pull request description: This is a rebased version of, and replaces, bitcoin-core/gui-qml#127 Introduces the actual `PeersIndicator` component and adds it to the `BlockClock` | Dark Mode | Light Mode | | --------- | ---------- | | <img width="752" alt="Screen Shot 2023-01-31 at 12 48 23 AM" src="https://user-images.githubusercontent.com/23396902/215676831-6573a94f-2030-4bf2-b45b-9d325be42600.png"> | <img width="752" alt="Screen Shot 2023-01-31 at 12 49 09 AM" src="https://user-images.githubusercontent.com/23396902/215676882-96f82c03-43ff-449d-b5d9-d7016fb0540b.png"> | [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/win64/insecure_win_gui.zip?branch=pull/236) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos/insecure_mac_gui.zip?branch=pull/236) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos_arm64/insecure_mac_arm64_gui.zip?branch=pull/236) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/android/insecure_android_apk.zip?branch=pull/236) ACKs for top commit: johnny9: ACK fc34996 Tree-SHA512: f5af2cd53bcecdb9441f412e94ad6557c48aad7998c2da69f1e0174682a0761151ca72b27a094b12d3f9055dff61694b9205297f5a4db9559bd0ed0ff3c4fdca
tx-signer450
added a commit
to tx-signer450/gui-qml
that referenced
this pull request
Oct 20, 2025
…dd to BlockClock fc34996357b8cb7830b1fbc26bc8f91575f88cff qml: add PeersIndicator to BlockClock (jarolrod) 5d0ea0ed5768109a60a86ec1a22e146812a1e021 qml: Add `PeersIndicator` component (Hennadii Stepanov) f5c2cd044833e8365224f382692d27ddcfa8f3d9 qml: Add `NodeModel::numOutboundPeers` property (Hennadii Stepanov) 475c63ef4752f7b79eca647072208f3a5be8d56e net: Notify about connection number by type (Hennadii Stepanov) Pull request description: This is a rebased version of, and replaces, bitcoin-core/gui-qml#127 Introduces the actual `PeersIndicator` component and adds it to the `BlockClock` | Dark Mode | Light Mode | | --------- | ---------- | | <img width="752" alt="Screen Shot 2023-01-31 at 12 48 23 AM" src="https://user-images.githubusercontent.com/23396902/215676831-6573a94f-2030-4bf2-b45b-9d325be42600.png"> | <img width="752" alt="Screen Shot 2023-01-31 at 12 49 09 AM" src="https://user-images.githubusercontent.com/23396902/215676882-96f82c03-43ff-449d-b5d9-d7016fb0540b.png"> | [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/win64/insecure_win_gui.zip?branch=pull/236) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos/insecure_mac_gui.zip?branch=pull/236) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos_arm64/insecure_mac_arm64_gui.zip?branch=pull/236) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/android/insecure_android_apk.zip?branch=pull/236) ACKs for top commit: johnny9: ACK fc34996357b8cb7830b1fbc26bc8f91575f88cff Tree-SHA512: f5af2cd53bcecdb9441f412e94ad6557c48aad7998c2da69f1e0174682a0761151ca72b27a094b12d3f9055dff61694b9205297f5a4db9559bd0ed0ff3c4fdca
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a rebased version of, and replaces, #127
Introduces the actual
PeersIndicatorcomponent and adds it to theBlockClock