Correction of the coin type in the testnet wallet example descriptors #1076
Correction of the coin type in the testnet wallet example descriptors #1076casey-bowman wants to merge 8 commits intobitcoindevkit:masterfrom
Conversation
… coin type correction
|
This looks good to me, thanks! Can you please squash your commits in a single one (or drop the first 5 commits altogether), and use conventional commits for the commit message? |
|
We're not using the |
I'll work on getting this squashed and rebased on master, after some other work I need to do, and switch to using the conventional commits spec, too. Thanks for all your work on BDK! It's been great working with it so far. |
…llet examples 21206fe fix: Correct the coin type in the derivation path for the three wallet examples (Casey Bowman) Pull request description: Corrects the derivation path for the three wallet examples. For testnet, the coin type should be 1 instead of 0. Replaces #1076 ACKs for top commit: danielabrozzoni: ACK 21206fe Tree-SHA512: c323d90f16f338a1a678e28aa681b28848d8c5f02fd769dbf165d3a13df7804abed14760cf0dbe2be6194b107b25980b54be4703f36a7db63f6484c244dd3728
|
Closed, superseded by PR #1089 |
Description
Corrects the derivation path for the three wallet examples. For testnet, the coin type should be 1 instead of 0.