Skip to content

Correction of the coin type in the testnet wallet example descriptors #1076

Closed
casey-bowman wants to merge 8 commits intobitcoindevkit:masterfrom
casey-bowman:casey/channel-factory
Closed

Correction of the coin type in the testnet wallet example descriptors #1076
casey-bowman wants to merge 8 commits intobitcoindevkit:masterfrom
casey-bowman:casey/channel-factory

Conversation

@casey-bowman
Copy link
Copy Markdown
Contributor

Description

Corrects the derivation path for the three wallet examples. For testnet, the coin type should be 1 instead of 0.

@danielabrozzoni
Copy link
Copy Markdown
Member

This looks good to me, thanks! Can you please squash your commits in a single one (or drop the first 5 commits altogether), and use conventional commits for the commit message?

@notmandatory
Copy link
Copy Markdown
Member

notmandatory commented Aug 16, 2023

We're not using the release/1.0.0-alpha branch so this PR needs to be merged to the master branch and you'll need to rebase on top of the master branch to pickup the latest commits.

@notmandatory notmandatory changed the base branch from release/1.0.0-alpha to master August 16, 2023 18:43
@casey-bowman
Copy link
Copy Markdown
Contributor Author

This looks good to me, thanks! Can you please squash your commits in a single one (or drop the first 5 commits altogether), and use conventional commits for the commit message?

I'll work on getting this squashed and rebased on master, after some other work I need to do, and switch to using the conventional commits spec, too.

Thanks for all your work on BDK! It's been great working with it so far.

danielabrozzoni added a commit that referenced this pull request Aug 25, 2023
…llet examples

21206fe fix: Correct the coin type in the derivation path for the three wallet examples (Casey Bowman)

Pull request description:

  Corrects the derivation path for the three wallet examples. For testnet, the coin type should be 1 instead of 0.

  Replaces #1076

ACKs for top commit:
  danielabrozzoni:
    ACK 21206fe

Tree-SHA512: c323d90f16f338a1a678e28aa681b28848d8c5f02fd769dbf165d3a13df7804abed14760cf0dbe2be6194b107b25980b54be4703f36a7db63f6484c244dd3728
@casey-bowman
Copy link
Copy Markdown
Contributor Author

Closed, superseded by PR #1089

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants