fix: Correct the coin type in the derivation path for wallet examples#1089
Merged
danielabrozzoni merged 1 commit intobitcoindevkit:masterfrom Aug 25, 2023
Merged
Conversation
Member
|
Thanks! Can you rebase on top of master? We recently merged a PR fixing the CI. |
30 tasks
casey-bowman
force-pushed
the
fix/cointype_correction
branch
from
a4933a9 to
bb6df4c
Compare
Contributor
Author
Done |
Member
|
Sadly this needs another rebase :/ |
casey-bowman
force-pushed
the
fix/cointype_correction
branch
2 times, most recently
from
fa5b07c to
8d7e8dc
Compare
Contributor
Author
|
Done |
…t examples fix: Correct the coin type in the derivation path for the three wallet examples
casey-bowman
force-pushed
the
fix/cointype_correction
branch
from
8d7e8dc to
21206fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrects the derivation path for the three wallet examples. For testnet, the coin type should be 1 instead of 0.
Replaces #1076