Skip to content

chore(chain)!: Rename Append to Merge#1502

Merged
notmandatory merged 1 commit intobitcoindevkit:masterfrom
LagginTimes:rename_append
Jul 8, 2024
Merged

chore(chain)!: Rename Append to Merge#1502
notmandatory merged 1 commit intobitcoindevkit:masterfrom
LagginTimes:rename_append

Conversation

@LagginTimes
Copy link
Copy Markdown
Contributor

Fixes #1467.

Description

Renames the Append trait to Merge.

Notes to the reviewers

Changelog notice

  • Rename bdk_chain::Append to bdk_chain::Merge.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

Copy link
Copy Markdown
Collaborator

@oleonardolima oleonardolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 4a12aac

@notmandatory notmandatory added the api A breaking API change label Jul 4, 2024
@notmandatory notmandatory added this to the 1.0.0-alpha milestone Jul 4, 2024
Copy link
Copy Markdown
Collaborator

@oleonardolima oleonardolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 4a12aac

Comment thread crates/chain/tests/test_keychain_txout_index.rs
Copy link
Copy Markdown
Collaborator

@oleonardolima oleonardolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 7b948d5

Copy link
Copy Markdown
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 962305f

@notmandatory notmandatory merged commit 43f093d into bitcoindevkit:master Jul 8, 2024
@notmandatory notmandatory mentioned this pull request Jul 20, 2024
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api A breaking API change

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Rename Append trait to Merge

3 participants