ci: add workspace or single package to build-test#1575
Closed
oleonardolima wants to merge 1 commit intobitcoindevkit:masterfrom
Closed
ci: add workspace or single package to build-test#1575oleonardolima wants to merge 1 commit intobitcoindevkit:masterfrom
workspace or single package to build-test#1575oleonardolima wants to merge 1 commit intobitcoindevkit:masterfrom
Conversation
It adds a new choice for the matrix strategy, being `--workspace` or a single package, i.e. `-p bdk_wallet`. It will then build and test for the whole workspace and each single package.
Collaborator
Author
|
Oh, wow! It really increase the number of checks on CI, I might rethink the approach. |
3 tasks
Member
|
@oleonardolima do you still want to rethink this or can we close it? |
Collaborator
Author
@notmandatory Oh, it's pretty stale! I'll rethink the approach, but we can close it for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1944
Description
I was going through the Project board and gave it a try as I'm already working with CI on
rust-esplora-client, and it looked simple.I was wondering if it should really be another job, I felt that adding to the matrix strategy it's simpler and clearer, let me know what you think.
Notes to the reviewers
I'm happy with either a new job or this approach (if it's sound), please let me know of any flaws with this one.
Changelog notice
--workspaceand-p <bdk-package>to CIbuild-testjob matrix strategy, to build and test the workspace and every single BDK package.Checklists
All Submissions:
cargo fmtandcargo clippybefore committing