ci: fix build-test job with --no-default-features, add miniscript/no-std#1636
Merged
ValuedMammal merged 1 commit intobitcoindevkit:masterfrom Oct 1, 2024
Conversation
Until rust-miniscript removes the no-std feature we need to enable it when --no-default-features is used to build bdk_wallet or the whole workspace. See also the check-no-std job which does the same plus enables the bdk_chain/hashbrown feature which is also needed to build bdk_wallet with --no-default-features but is already enabled when building the whole workspace.
Merged
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the CI
build-testjob with--no-default-featuresby also adding--features miniscript/no-std.Until
rust-miniscriptremoves theno-stdfeature we need to enable it when--no-default-featuresis used to buildbdk_walletor the whole workspace. See also thecheck-no-stdjob which does the same plus enables thebdk_chain/hashbrownfeature which is also needed to buildbdk_walletwith--no-default-featuresbut is already enabled when building the whole workspace.Notes to the reviewers
I think we didn't catch this on #1625 because the CI job names changed and I didn't update the branch merge requirements. Another possibility is it was passing because of cached build artifacts which I removed last night when I was trying to troubleshoot something else. I've updated the required CI jobs that need to pass before allowing a PR to be merged to
masterto include the ones with--no-default-features --features bdk_chain/hashbrownin the name.Checklists
All Submissions:
cargo fmtandcargo clippybefore committing