Borrow instead of moving transaction when broadcasting#452
Merged
notmandatory merged 1 commit intobitcoindevkit:masterfrom Oct 27, 2021
Merged
Conversation
klochowicz
force-pushed
the
borrow-transaction-for-broadcasting
branch
from
1f87367 to
535f600
Compare
Contributor
rajarshimaitra
left a comment
rajarshimaitra
left a comment
There was a problem hiding this comment.
Concept ACK. It seems unnecessary to move the tx while the internal broadcast is using reference itself.
klochowicz
force-pushed
the
borrow-transaction-for-broadcasting
branch
from
535f600 to
c0695f8
Compare
Member
|
Concept ACK, this needs to be rebased on top of #454 to fix the CI and then we can merge it |
There's no need to take ownership of the transaction for a broadcast.
klochowicz
force-pushed
the
borrow-transaction-for-broadcasting
branch
from
c0695f8 to
3d8efbf
Compare
Contributor
Author
rebased! hopefully the tests will pass this time. |
notmandatory
approved these changes
Oct 27, 2021
Member
notmandatory
left a comment
notmandatory
left a comment
There was a problem hiding this comment.
ACK 3d8efbf
Thanks, nice fix.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Cleanup - don't need to move transaction when broadcasting
All Submissions:
cargo fmtandcargo clippybefore committingBugfixes:
I guess it breaks the API, albeit in a really trivial way (
clippyshould suggest using a borrow)