Fix/ci update 1.56#454
Merged
notmandatory merged 3 commits intobitcoindevkit:masterfrom Oct 26, 2021
Merged
Conversation
afilini
force-pushed
the
fix/ci-update-1.56
branch
4 times, most recently
from
6963d40 to
3fb5d70
Compare
afilini
force-pushed
the
fix/ci-update-1.56
branch
from
3fb5d70 to
d75d221
Compare
Contributor
rajarshimaitra
left a comment
rajarshimaitra
left a comment
There was a problem hiding this comment.
tACK
Are those refs changes required for the previous version update changes? Its working ok too without the refs changes.
| .scan(checkpoint, |prev_header, ((_, filter_content), header)| { | ||
| let filter = BlockFilter::new(&filter_content); | ||
| if header != filter.filter_header(&prev_header) { | ||
| if header != filter.filter_header(prev_header) { |
Contributor
There was a problem hiding this comment.
Are moving objects instead of passing refs more efficient for these cases for some reason?
Member
Author
There was a problem hiding this comment.
This was actually a clippy error, I'm not sure why the explicit & is not needed, but clearly the compiler can infer that it's a reference.
If you tried running clippy locally maybe you forgot to enable the compact_filters feature? This would explain why you didn't get anything
This was referenced Oct 26, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update our CI to use
1.56, pin some dependencies to maintain our MSRV.Closes #439.
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingBugfixes: