Update codecov@v2#458
Merged
afilini merged 1 commit intobitcoindevkit:masterfrom Nov 8, 2021
Merged
Conversation
Contributor
Author
|
rust version 1.46.0 is failing build test is failing, even in current master. |
Member
|
I think it's time to update our MSRV, what are your thoughts for #457? This should fix the build issues we've been getting lately. |
Member
|
Try rebasing on #454 first, that should fix the CI |
rajarshimaitra
force-pushed
the
codecov-v2
branch
from
b891396 to
dd30e54
Compare
Contributor
Author
|
Rebased on #457, CI passing now. |
Member
rajarshimaitra
force-pushed
the
codecov-v2
branch
from
dd30e54 to
2ffae5e
Compare
Contributor
Author
|
Thanks. Rebased on master. |
Member
|
Now you just need to do a |
rajarshimaitra
force-pushed
the
codecov-v2
branch
from
2ffae5e to
3b2b559
Compare
Contributor
Author
|
Ok, Does this look correct? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #447.
Notes to the reviewers
Some checks are failing on current master.
Checklists
All Submissions:
cargo fmtandcargo clippybefore committing