Update MSRV to 1.51, enable cargo resolver = "2"#457
Closed
notmandatory wants to merge 1 commit intobitcoindevkit:masterfrom
Closed
Update MSRV to 1.51, enable cargo resolver = "2"#457notmandatory wants to merge 1 commit intobitcoindevkit:masterfrom
notmandatory wants to merge 1 commit intobitcoindevkit:masterfrom
Conversation
6beed39 to
04cbfc9
Compare
rajarshimaitra
approved these changes
Oct 26, 2021
Contributor
rajarshimaitra
left a comment
There was a problem hiding this comment.
tACK.
To me it seems MSRV to 1.51 is the right way to go.
Although interested to know if there's any hidden catch.
Member
|
Concept ACK on bumping the MSRV, but I would discuss about this in the call to see if we can get away with a lower version. The two errors I had to fix for #454 for instance were not related to the resolver, so maybe we can find a compromise to keep using a version that is more widely available without having too many issues. |
This is required to keep using dependencies that have switched to MSRV 1.51 which requires the resolver version 2: tiny-bip39, ahash, and object.
04cbfc9 to
36fe4f4
Compare
Member
Author
|
Rebased on |
Member
Author
|
I have a proposal for an updated MSRV policy in #331 and based on decision there will update this PR. |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is required to keep using dependencies that have switched to MSRV 1.51 which requires the resolver version 2: tiny-bip39, ahash, and object.
Notes to the reviewers
Current Debian stable (bullseye) includes Rust 1.48.0, and testing (bookworm) includes Rust 1.50.0. If this is a concern I'm open to other suggestions on how to avoid running into the resolver errors we've been getting hit with lately.
Prior to merging this PR our branch checks will need to be updated to require the 1.51.0 tests instead of the ones for 1.48.0.
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features:
CHANGELOG.mdBugfixes: