Release/0.13.0

[notmandatory]

Description

Merge the 0.13.0 bdk release into the master branch.

Notes to the reviewers

Additional changes made in release branch:

• Cherry picked commits from Fix/ci update 1.56 #454
• Update dev-dependencies electrsd to 0.12 ee8b992
• Switch back to rust-bitcoin/rust-bitcoincore-rpc 8781599

Checklists

All Submissions:

• I've signed all my commits
• I followed the contribution guidelines
• I ran cargo fmt and cargo clippy before committing

[codecov-commenter]

Codecov Report

Merging #453 (f6f7366) into master (59f795f) will decrease coverage by 0.00%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master     #453      +/-   ##
==========================================
- Coverage   72.95%   72.95%   -0.01%     
==========================================
  Files          34       34              
  Lines        7426     7427       +1     
==========================================
  Hits         5418     5418              
- Misses       2008     2009       +1     

Impacted Files	Coverage Δ
src/blockchain/compact_filters/mod.rs	0.00% <ø> (ø)
src/blockchain/compact_filters/peer.rs	0.00% <0.00%> (ø)
src/blockchain/compact_filters/store.rs	0.00% <0.00%> (ø)
src/blockchain/compact_filters/sync.rs	0.00% <ø> (ø)
src/error.rs	19.11% <ø> (ø)
src/keys/bip39.rs	97.18% <100.00%> (ø)
src/lib.rs	83.23% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59f795f...f6f7366. Read the comment docs.

[notmandatory]

cargo-audit found two issue we'll need to fix before 0.13.0 is ready.

Crate: time
Version: 0.1.43
Title: Potential segfault in the time crate
Date: 2020-11-18
ID: RUSTSEC-2020-0071
URL: https://rustsec.org/advisories/RUSTSEC-2020-0071
Solution: Upgrade to >=0.2.23
Dependency tree:
time 0.1.43
└── zip 0.5.13
└── electrsd 0.10.0
└── bdk 0.13.0-rc.1

Crate: failure
Version: 0.1.8
Warning: unmaintained
Title: failure is officially deprecated/unmaintained
Date: 2020-05-02
ID: RUSTSEC-2020-0036
URL: https://rustsec.org/advisories/RUSTSEC-2020-0036
Dependency tree:
failure 0.1.8
└── tiny-bip39 0.7.3
└── bdk 0.13.0-rc.1

error: 1 vulnerability found!
warning: 1 allowed warning found

[notmandatory]

I've created a PR to update the zip crate to use the latest version of time, hopefully this gets merged and released soon, and then we'll also need a new version of electrsd from @RCasatta .
zip-rs/zip-old#254

[notmandatory]

Instead of requiring a change to the zip crate I created an electrsd PR that should fix this issue, see RCasatta/electrsd#23.

[RCasatta]

electrsd with RCasatta/electrsd#23 merged and released as 0.12.0 (also with electrs 0.9.1)

[notmandatory]

Added commits to switch to electrs 0.12 and to switch the rest of BDK back to rust-bitcoin/rust-bitcoincore-rpc.

[afilini]

There are conflicts on Cargo.toml, I don't know which one of the two libraries is the right one: core-rpc i believe is published by @RCasatta, do we still need to use it or we can switch back to bitcoincore-rpc?

[RCasatta]

I confirm we need to switch back to rust-bitcoincore-rpc now that they have upgraded rust-bitcoin and released