Update logo

[afilini]

Description

Update the logo in our readme

[RCasatta]

this reminds me that is possible to change the logo also in the documentation, see https://www.davideaversa.it/blog/how-to-add-a-logo-in-rust-documentation/

[rajarshimaitra]

ACK. Also on rust.doc as mentioned by @RCasatta .

[notmandatory]

It's weird we're getting this clippy error, I think it has something to do with the macro running with nightly since this warning is only present in master/nightly:

https://rust-lang.github.io/rust-clippy/master/index.html#no_effect_underscore_binding

[notmandatory]

I'm a bit stumped on this no_effect_underscore_binding issue.. I get the error with clippy 1.46.0, 1.47.0, 1.48.0.. those are all I tried. But I don't get the error with 1.56 or nightly.

Any ideas?

Reproduce with:

cargo +1.46.0 clippy --all-targets --features async-interface --no-default-features

[rajarshimaitra]

I am not getting the error in 1.46.0, 1.47.0 and 1.56.0.

Though I am getting a new clippy error in stable and nightly (1.57.0 and 1.59.0). Probably that's due to some recent changes in 1.57.0.

$ cargo +stable clippy --all-targets --features async-interface --no-default-features -- -D warnings
    Checking bdk v0.14.1-dev (/home/raj/github-repo/bdk)
    Checking bitcoind v0.21.0
    Checking electrsd v0.13.0
error: manual implementation of `split_once`
  --> src/wallet/export.rs:99:5
   |
99 |     s.splitn(2, '#').next().map(String::from).unwrap()
   |     ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `Some(s.split_once('#').map_or(&*s, |x| x.0))`
   |
   = note: `-D clippy::manual-split-once` implied by `-D warnings`
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_split_once

error: this `impl` can be derived
   --> src/wallet/signer.rs:482:1
    |
482 | / impl Default for SignOptions {
483 | |     fn default() -> Self {
484 | |         SignOptions {
485 | |             trust_witness_utxo: false,
...   |
489 | |     }
490 | | }
    | |_^
    |
    = note: `-D clippy::derivable-impls` implied by `-D warnings`
    = help: try annotating `wallet::signer::SignOptions` with `#[derive(Default)]`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls

They seem unrelated to this error and straight forward, probably something we need to deal in next latest stable update.

But I can't reproduce the no_effect_underscore_binding error in my local.

Is it possible to rerun the CI tests?

[notmandatory]

Now that #501 is in you can rebase on master to fix the CI issue.

[afilini]

this reminds me that is possible to change the logo also in the documentation, see https://www.davideaversa.it/blog/how-to-add-a-logo-in-rust-documentation/

I can do this in another PR once this is merged, so that i can point the url to the image hosted on github. Otherwise I have to upload it somewhere else just to have a publicly accessible url that i can use.

[notmandatory]

ACK 77bce06