Skip to content

Only run clippy for the stable rust version#501

Merged
notmandatory merged 1 commit intobitcoindevkit:masterfrom
notmandatory:ci_clippy_fix
Dec 16, 2021
Merged

Only run clippy for the stable rust version#501
notmandatory merged 1 commit intobitcoindevkit:masterfrom
notmandatory:ci_clippy_fix

Conversation

@notmandatory
Copy link
Copy Markdown
Member

@notmandatory notmandatory commented Dec 15, 2021

Description

It was decided during the team call today (2021-12-14) to only run clippy for the stable rust version.

Notes to the reviewers

This is required to fix the below build issues when running clippy on rust version 1.46.0.

cargo clippy --all-targets --features async-interface --no-default-features -- -D warnings
...

Checking bitcoincore-rpc v0.14.0
error: unknown clippy lint: clippy::no_effect_underscore_binding
  --> src/blockchain/mod.rs:88:1
   |
88 | #[maybe_async]
   | ^^^^^^^^^^^^^^
   |
   = note: `-D clippy::unknown-clippy-lints` implied by `-D warnings`
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unknown_clippy_lints
   = note: this error originates in an attribute macro (in Nightly builds, run with -Z macro-backtrace for more info)

error: unknown clippy lint: clippy::no_effect_underscore_binding
   --> src/blockchain/mod.rs:220:1
    |
220 | #[maybe_async]
    | ^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unknown_clippy_lints
    = note: this error originates in an attribute macro (in Nightly builds, run with -Z macro-backtrace for more info)

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@notmandatory notmandatory force-pushed the ci_clippy_fix branch 2 times, most recently from 88917ef to 26044f6 Compare December 15, 2021 06:17
@notmandatory notmandatory requested a review from afilini December 15, 2021 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants