Don't default to use async/await on wasm32#831
Merged
notmandatory merged 1 commit intobitcoindevkit:masterfrom Jan 30, 2023
Merged
Conversation
This was referenced Jan 10, 2023
tnull
force-pushed
the
2023-01-macros-dont-default-to-async-on-wasm
branch
4 times, most recently
from
6aa070b to
033e413
Compare
Member
tnull
force-pushed
the
2023-01-macros-dont-default-to-async-on-wasm
branch
from
033e413 to
eb11679
Compare
Contributor
Author
Contributor
Author
|
@notmandatory Mh, seems the CI failures are unrelated as they also happen on current master? |
Member
Oh drat.. I'm looking into it now. |
Member
|
Please take a look and hold off on rebasing until we decide on this PR: #842 |
Member
|
We've bumped MSRV to 1.57.0, please rebase. |
We don't automatically want to make the interface `async` based on the used architecture, but now require the user to explicitly set the `async-interface` feature.
tnull
force-pushed
the
2023-01-macros-dont-default-to-async-on-wasm
branch
from
eb11679 to
32912ea
Compare
Contributor
Author
Rebased on master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We don't automatically want to make the interface
asyncbased on the used architecture, but now require the user to explicitly set theasync-interfacefeature.All Submissions:
cargo fmtandcargo clippybefore committing