Bump project MSRV to 1.57.0#842
Merged
notmandatory merged 1 commit intobitcoindevkit:masterfrom Jan 27, 2023
Merged
Conversation
Member
Author
|
I'm favoring this option since MSRVs and dependencies will change anyway when we get the |
This was referenced Jan 24, 2023
Merged
a6d3823 to
f45f451
Compare
f45f451 to
b02bfb3
Compare
This was referenced Jan 30, 2023
notmandatory
added a commit
that referenced
this pull request
Feb 2, 2023
147a4ed Update electrsd to version 0.22 (Steve Myers) Pull request description: ### Description Update `electrsd` dev-dependency to version `0.22`. ### Notes to the reviewers We're able to do this now that esplora was updated in #830 and our MSRV was bumped to `1.57.0` in #842. ### Changelog None. ### Checklists #### All Submissions: * [x] I've signed all my commits * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md) ACKs for top commit: rajarshimaitra: ACK 147a4ed Tree-SHA512: 20e0aebb02d786a4d426a2d2e66b78225a803eee2c2f6092b0cf8f18e6fe91e37ef7a74e109e3ad4d734af8de4dc71598f7e80f50d40187442dad323000c6090
This was referenced Feb 2, 2023
Closed
Member
Author
|
We're planning to move MSRV down as soon as we can find replacements or test version or features re-configs for the dependencies that are causing us to move up. See #331 for some preliminary analysis. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bump project MSRV from 1.56.1 to 1.57.0.
Also bumped the
check-wasmandtest_hardware_walletjobs rust STABLE version to 1.65.0 to match other jobs.Notes to the reviewers
The
rustlscrate changed their MSRV to 1.57 on 2023-01-12 with a patch release from 0.20.7 to 0.20.8, rustls/rustls#1152. This breaks our CI builds that useesplora-client0.3 because it depends on a version ofureqthat uses the latestrustls.https://github.com/rustls/rustls/blob/main/README.md
Changelog notice
Project MSRV changed from 1.56.1 to 1.57.0.
Checklists
All Submissions:
cargo fmtandcargo clippybefore committing