Simplify reveal_to_target logic#890
Merged
evanlinjin merged 1 commit intobitcoindevkit:masterfrom Mar 18, 2023
Merged
Conversation
evanlinjin
force-pushed
the
simplify-reveal-to-target-logic
branch
from
fdca1aa to
0caad68
Compare
vladimirfomene
approved these changes
Mar 16, 2023
Contributor
vladimirfomene
left a comment
vladimirfomene
left a comment
There was a problem hiding this comment.
Nice one. This version of the code is easy to follow. I just have a nit.
| ); | ||
|
|
||
| // if we need to reveal new indexes, the latest revealed index goes here | ||
| let mut reveal_to_index = None; |
Contributor
There was a problem hiding this comment.
Maybe you should call this latest_reveal_index. It might remove the need to have a comment.
Member
Author
There was a problem hiding this comment.
I think we probably need a comment anyway to inform that this variable is to be mutated "if we need to reveal new indices".
LLFourn
reviewed
Mar 17, 2023
LLFourn
approved these changes
Mar 17, 2023
- Remove unnecessary check - Better comments - Better variable names - Add test for scanning txouts with lookahead
evanlinjin
force-pushed
the
simplify-reveal-to-target-logic
branch
from
0caad68 to
72b1e2a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features: