Set bitcoin, miniscript default-features = false, bump esplora-client version to 0.4#893
Closed
notmandatory wants to merge 1 commit intobitcoindevkit:masterfrom
Closed
Conversation
notmandatory
force-pushed
the
disable_default_features
branch
from
3274d60 to
019ecc4
Compare
evanlinjin
requested changes
Mar 16, 2023
Member
evanlinjin
left a comment
evanlinjin
left a comment
There was a problem hiding this comment.
Shouldn't it be default-features?
notmandatory
force-pushed
the
disable_default_features
branch
from
019ecc4 to
109814f
Compare
Member
Author
Oh drat! you are correct. I fixed that but now getting weird errors. I'll take this PR out of the alpha.0 milestone until I can figure out what's going on. |
Member
|
@notmandatory I can take over. I think I know whats up |
Member
|
Fixed in #894 |
notmandatory
added a commit
that referenced
this pull request
Jun 20, 2023
7ab84be Better no-std support (Steve Myers) Pull request description: This replaces #893 ### Description Carrying over relevant maintenance changes from release 0.27.2 to bdk `master`. - Use `default-features = false` for `miniscript` and `bitcoin` - Introduce `std` features for `bdk`, `bdk_chain` and `bdk_esplora` ### Notes to the reviewers The `default-features = false`for `bitcoin` and `miniscript` is to let `bdk` be unbiased for things like no-std. ### Changelog notice - Set default-features = false for rust-bitcoin and rust-miniscript #894 - Introduce `std` features for `bdk`, `bdk_chain` and `bdk_esplora` ### Checklists #### All Submissions: * [x] I've signed all my commits * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md) * [x] I ran `cargo fmt` and `cargo clippy` before committing ACKs for top commit: notmandatory: ACK 7ab84be Tree-SHA512: 217e0ebc04cd59898d4de1c4f8cc6c87de2561659e277cc6e0d969c8bc61142ca62c8bda86643d55676dce39da25891b516a901005a03a31404dae118a5fce76
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Carrying over relevant maintenance changes from release 0.27.2 to bdk
master. Setting bitcoin and miniscriptdefault-features = false. Bumped esplora-client to 0.4.Notes to the reviewers
The
default-features = falseis to let bdk be unbiased for things like no-std.Changelog notice
default-features = falsefor rust-bitcoin and rust-miniscript #882Checklists
All Submissions:
cargo fmtandcargo clippybefore committing