Skip to content

Update esplora client dependency to version 0.4#884

Merged
notmandatory merged 1 commit intobitcoindevkit:release/0.27from
notmandatory:update_esplora_client
Mar 15, 2023
Merged

Update esplora client dependency to version 0.4#884
notmandatory merged 1 commit intobitcoindevkit:release/0.27from
notmandatory:update_esplora_client

Conversation

@notmandatory
Copy link
Copy Markdown
Member

@notmandatory notmandatory commented Mar 6, 2023 •
edited
Loading

Description

Update the esplora-client to the new 0.4 release.

Notes to the reviewers

The esplora-client was updated in bitcoindevkit/rust-esplora-client#39 to not include default rust-bitcoin dependencies.

Changelog notice

  • Update the esplora-client optional dependency to version 0.4.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@notmandatory notmandatory self-assigned this Mar 6, 2023
@notmandatory notmandatory changed the title Update esplora client Update esplora client dependency to version 0.4 Mar 6, 2023
@notmandatory notmandatory changed the base branch from master to release/0.27 March 6, 2023 23:49
@notmandatory notmandatory force-pushed the update_esplora_client branch from d4db955 to 19bec38 Compare March 7, 2023 00:08
@benthecarman
Copy link
Copy Markdown
Contributor

benthecarman commented Mar 9, 2023

If this is rebased it should work now

@notmandatory notmandatory force-pushed the update_esplora_client branch from 19bec38 to 1a6f669 Compare March 13, 2023 16:36
@notmandatory
Copy link
Copy Markdown
Member Author

notmandatory commented Mar 13, 2023

We should have the rust-esplora-client 0.4 out tomorrow and then will update this PR and get it into the 0.27.2 release.

@notmandatory notmandatory mentioned this pull request Mar 13, 2023
Closed
22 tasks
@notmandatory notmandatory force-pushed the update_esplora_client branch from 1a6f669 to bb2b2d6 Compare March 15, 2023 04:14
@notmandatory notmandatory marked this pull request as ready for review March 15, 2023 04:16
vladimirfomene
vladimirfomene approved these changes Mar 15, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@vladimirfomene vladimirfomene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK bb2b2d6

rajarshimaitra
rajarshimaitra approved these changes Mar 15, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@rajarshimaitra rajarshimaitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK bb2b2d6

@notmandatory notmandatory merged commit e8acafc into bitcoindevkit:release/0.27 Mar 15, 2023
This was referenced Mar 15, 2023
Closed
Closed
@evanlinjin evanlinjin mentioned this pull request Mar 16, 2023
Merged
3 tasks
@notmandatory notmandatory modified the milestones: 0.27.2, 0.28.0 Mar 28, 2023
@notmandatory notmandatory mentioned this pull request Apr 11, 2023
Closed
11 tasks
@notmandatory notmandatory deleted the update_esplora_client branch May 26, 2025 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@vladimirfomene vladimirfomene vladimirfomene approved these changes

@rajarshimaitra rajarshimaitra rajarshimaitra approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@notmandatory notmandatory

Labels

None yet

Projects

None yet

Milestone

0.28.0

Development

Successfully merging this pull request may close these issues.

4 participants

@notmandatory @benthecarman @vladimirfomene @rajarshimaitra