Leave rust-bitcoin compilation flags untouched#39
Merged
notmandatory merged 1 commit intobitcoindevkit:masterfrom Mar 13, 2023
Merged
Leave rust-bitcoin compilation flags untouched#39notmandatory merged 1 commit intobitcoindevkit:masterfrom
rust-bitcoin compilation flags untouched#39notmandatory merged 1 commit intobitcoindevkit:masterfrom
Conversation
Because `wasm_bindgen` enables a hobbled `std` mode by default (where you can "use" the full std, but random bits of it panic), `wasm_bindgen` users really should use `no_std` builds where possible. However, cargo makes this very difficult - crates with `no_std` flags can be silently made `std` just by one dependency setting the flag silently. This happens here by leaving default-features enabled. Luckily, we can simply disable `default-features` and everything else remains.
This was referenced Mar 4, 2023
Pull Request Test Coverage Report for Build 4328703035
💛 - Coveralls |
3 tasks
notmandatory
added a commit
to bitcoindevkit/bdk
that referenced
this pull request
Mar 15, 2023
bb2b2d6 Update esplora-client dependency to version 0.4 (Steve Myers) Pull request description: ### Description Update the `esplora-client` to the new `0.4` release. ### Notes to the reviewers The `esplora-client` was updated in bitcoindevkit/rust-esplora-client#39 to not include default `rust-bitcoin` dependencies. ### Changelog notice - Update the `esplora-client` optional dependency to version `0.4`. ### Checklists #### All Submissions: * [x] I've signed all my commits * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md) * [x] I ran `cargo fmt` and `cargo clippy` before committing ACKs for top commit: vladimirfomene: ACK bb2b2d6 rajarshimaitra: tACK bb2b2d6 Tree-SHA512: 0f277106166ab4a8144a641ac9507f1a32d735f99c0b73a026ff6e0b82589110a71fe81f880caa01dab247572f3146b771cc28bdab5b22bcd87ff628e15b2e1a
chrono-raven6i90
added a commit
to chrono-raven6i90/rust-esplora-client
that referenced
this pull request
Oct 28, 2025
…ilation flags untouched
ac52e9525e8bfa29d3f1e1e8a132eaa8444c36ce Leave `rust-bitcoin` compilation flags untouched (Matt Corallo)
Pull request description:
Because `wasm_bindgen` enables a hobbled `std` mode by default (where you can "use" the full std, but random bits of it panic), `wasm_bindgen` users really should use `no_std` builds where possible. However, cargo makes this very difficult - crates with `no_std` flags can be silently made `std` just by one dependency setting the flag silently.
This happens here by leaving default-features enabled. Luckily, we can simply disable `default-features` and everything else remains.
ACKs for top commit:
notmandatory:
ACK ac52e9525e8bfa29d3f1e1e8a132eaa8444c36ce
Tree-SHA512: a42d0dbfb1b07f7e218e887c6cb8b4b74b3c5854db3d596a7e8e259a4b54b6737bca9997cff22bbf8768d93b300616e03a79c153106cb23b57022b882afcb8b1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
wasm_bindgenenables a hobbledstdmode by default (where you can "use" the full std, but random bits of it panic),wasm_bindgenusers really should useno_stdbuilds where possible. However, cargo makes this very difficult - crates withno_stdflags can be silently madestdjust by one dependency setting the flag silently.This happens here by leaving default-features enabled. Luckily, we can simply disable
default-featuresand everything else remains.