fix: apply linting and formatting fixes#407
Merged
Jamie-BitFlight merged 3 commits intomainfrom Nov 5, 2025
Merged
Conversation
Add matrix testing strategy to prepare for GitHub Actions' upcoming Node 24 migration (Fall 2025). This ensures compatibility across: - Node 20.0.0 (minimum supported version) - Node 20.17.0 (latest Node 20.x) - Node 24.x (upcoming default for GitHub Actions) Changes: - Add matrix strategy to test workflow with fail-fast: false - Update package.json engines to support Node 20-24 (>=20.0.0 <25.0.0) - Pass matrix node-version to setup-node action - Update job name to show tested Node version The action.yml still uses node20 runtime, but this prepares the codebase for future migration when GitHub Actions supports node24.
- Fix ESLint no-return-await errors in test files - Apply Prettier formatting (quote style in workflow) - Regenerate type definitions after build - Update package-lock.json Changes made during validation: - Removed redundant await from return statements in vi.mock() calls - Prettier converted single quotes to double quotes in test.yml
WalkthroughThe PR expands Node.js version support (up to v24.x) in package.json and adds a test matrix strategy to validate against multiple Node versions (20.0.0, 20.17.0, 24.x). Test mock implementations are simplified by removing unnecessary await keywords in dynamic imports across four test files. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes
Possibly related PRs
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (1 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Coverage Report
File CoverageNo changed files found. |
This was referenced Nov 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Related Issues
Changes Made
Testing
Checklist
Screenshots (if applicable)
Additional Notes
Summary by CodeRabbit
Tests
Chores