Skip to content

fix: use Node 24 for semantic-release to satisfy version requirement#411

Merged
Jamie-BitFlight merged 1 commit intomainfrom
claude/fix-semantic-release-node-version-011CUpBbScMduUTctqgM3pYN
Nov 5, 2025
Merged

fix: use Node 24 for semantic-release to satisfy version requirement#411
Jamie-BitFlight merged 1 commit intomainfrom
claude/fix-semantic-release-node-version-011CUpBbScMduUTctqgM3pYN

Conversation

@Jamie-BitFlight
Copy link
Contributor

@Jamie-BitFlight Jamie-BitFlight commented Nov 5, 2025

Description

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code refactoring
  • Performance improvement
  • Test update
  • Build/CI update
  • Other (please describe):

Related Issues

  • Fixes #
  • Related to #

Changes Made

Testing

  • All existing tests pass
  • Added new tests for new functionality
  • Manually tested the changes
  • Updated documentation

Checklist

  • My code follows the project's code style
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings or errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published

Screenshots (if applicable)

Additional Notes

Summary by CodeRabbit

  • Chores
    • Updated build pipeline to use Node.js version 24.x for deployment processes.

semantic-release@latest (v25.0.1) requires Node ^22.14.0 || >= 24.10.0
but the deploy workflow was using Node 20.19.5, causing the release
step to fail.

This adds a setup-node step before semantic-release to switch to
Node 24.x while keeping the build/test steps on Node 20.x.
@coderabbitai
Copy link

coderabbitai bot commented Nov 5, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

A new step "Setup Node 24 for semantic-release" is added to the Deploy NPM workflow using actions/setup-node@v4 with node-version set to 24.x, positioned before the semantic-release execution.

Changes

Cohort / File(s) Summary
GitHub Workflow Configuration
.github/workflows/deploy.yml
Added Node 24 setup step with actions/setup-node@v4 before semantic-release execution

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch claude/fix-semantic-release-node-version-011CUpBbScMduUTctqgM3pYN

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d6d38fc and 5e0acc4.

📒 Files selected for processing (1)
  • .github/workflows/deploy.yml (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Jamie-BitFlight Jamie-BitFlight merged commit 529a2d2 into main Nov 5, 2025
8 checks passed
@Jamie-BitFlight Jamie-BitFlight deleted the claude/fix-semantic-release-node-version-011CUpBbScMduUTctqgM3pYN branch November 5, 2025 08:43
@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 49.81% 402 / 807
🔵 Statements 50.48% 414 / 820
🔵 Functions 65.74% 71 / 108
🔵 Branches 49.38% 200 / 405
File CoverageNo changed files found.
Generated in workflow #239 for commit 5e0acc4 by the Vitest Coverage Report Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants