Skip to content

Feat/insight eth#2351

Merged
matiu merged 13 commits into
bitpay:masterfrom
gabrielbazan7:feat/insight-eth
Aug 30, 2019
Merged

Feat/insight eth#2351
matiu merged 13 commits into
bitpay:masterfrom
gabrielbazan7:feat/insight-eth

Conversation

@gabrielbazan7
Copy link
Copy Markdown
Contributor

@gabrielbazan7 gabrielbazan7 commented Aug 26, 2019 •
edited
Loading

needs #2355

@justinkook
Copy link
Copy Markdown
Contributor

justinkook commented Aug 26, 2019

Seems like I have to update @types/node to the latest version to successfully run this branch. I get error:

typescript error: 2694 Namespace 'NodeJS' has no exported member 'ProcessEnv'.

@gabrielbazan7 gabrielbazan7 force-pushed the feat/insight-eth branch 2 times, most recently from acf508d to dc08633 Compare August 26, 2019 19:39
@gabrielbazan7 gabrielbazan7 changed the title WIP Feat/insight eth Feat/insight eth Aug 26, 2019
@gabrielbazan7 gabrielbazan7 changed the title Feat/insight eth WIP Feat/insight eth Aug 29, 2019
@gabrielbazan7 gabrielbazan7 changed the title WIP Feat/insight eth Feat/insight eth Aug 29, 2019
rastajpa
rastajpa approved these changes Aug 29, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@rastajpa rastajpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK! Nice work!

Gamboster
Gamboster approved these changes Aug 29, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@Gamboster Gamboster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Great job!

cmgustavo
cmgustavo approved these changes Aug 29, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@cmgustavo cmgustavo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK! great work!

@matiu matiu merged commit 7ce2898 into bitpay:master Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@cmgustavo cmgustavo cmgustavo approved these changes

@rastajpa rastajpa rastajpa approved these changes

@Gamboster Gamboster Gamboster approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@gabrielbazan7 @justinkook @cmgustavo @rastajpa @Gamboster @matiu