[Feat] Check if valid API#2355
Merged
Merged
Conversation
micahriggan
suggested changes
Aug 28, 2019
| } | ||
|
|
||
| private isValidEthereumAddress(chain, network, add): boolean { | ||
| return !!Validation.validateAddress(chain, network, add); |
Contributor
There was a problem hiding this comment.
We should be able to use Validation.validateAddress for all the chains, otherwise we need to update that method to where that is true.
| return !!bitcoreLib.Address.isValid(data, 'testnet'); | ||
| } | ||
|
|
||
| private isValidBitcoinCashLegacyMainnetAddress(data: string): boolean { |
Contributor
There was a problem hiding this comment.
Chain specific api logic goes into packages/bitcore-node/src/providers/chain-state/${chain}/${chain}.ts
| this.isValidBitcoinCashLegacyMainnetAddress(addr) | ||
| ); | ||
| } else if(chain.toLowerCase() === 'eth') { | ||
| return this.isValidEthereumAddress('eth', network, addr); |
Contributor
There was a problem hiding this comment.
The ethereum logic can go in packages/bitcore-node/src/modules/ethereum/api/csp.ts
Each chain's CSP should implement this isValidAddress method
gabrielbazan7
force-pushed
the
feat/valid
branch
2 times, most recently
from
767c526 to
b06fe9f
Compare
gabrielbazan7
changed the title
micahriggan
reviewed
Aug 28, 2019
| getCoinsForTx(params: { chain: string; network: string; txid: string }): Promise<CoinListingJSON>; | ||
| getLocalTip(params): Promise<IBlock | null>; | ||
| getLocatorHashes(params): Promise<any>; | ||
| isValid(params): {isValid: boolean, type:string}; |
Contributor
There was a problem hiding this comment.
params: {input: string}
micahriggan
reviewed
Aug 28, 2019
| private isValidAddress(params): boolean { | ||
| const { chain, network, input } = params; | ||
| const addr = this.extractAddress(input); | ||
| return this.validateAddress(chain.toLowerCase(), network, addr); |
Contributor
There was a problem hiding this comment.
Can we consolidate the logic of isValidAddress and validateAddress?
does Validation.validateAddress require the adddress to be extracted?
micahriggan
reviewed
Aug 28, 2019
| } | ||
| } | ||
|
|
||
| private isValidBlockOrTx(inputValue): boolean { |
gabrielbazan7
force-pushed
the
feat/valid
branch
from
b06fe9f to
cba8191
Compare
gabrielbazan7
changed the title
micahriggan
reviewed
Aug 29, 2019
| getCoinsForTx(params: { chain: string; network: string; txid: string }): Promise<CoinListingJSON>; | ||
| getLocalTip(params): Promise<IBlock | null>; | ||
| getLocatorHashes(params): Promise<any>; | ||
| isValid(params:{ input: string }): {isValid: boolean, type:string}; |
Contributor
There was a problem hiding this comment.
Seems like chain and network should be in the typing for params, since
const { chain, network, input } = params;
on line 577
Contributor
Author
There was a problem hiding this comment.
Done ! Thanks !
Merged
gabrielbazan7
force-pushed
the
feat/valid
branch
from
cba8191 to
4978d25
Compare
gabrielbazan7
force-pushed
the
feat/valid
branch
from
4978d25 to
8947de5
Compare
bsnowden3
pushed a commit
to bsnowden3/bitcore
that referenced
this pull request
Sep 11, 2019
[Feat] Check if valid API
bsnowden3
pushed a commit
to bsnowden3/bitcore
that referenced
this pull request
Sep 12, 2019
[Feat] Check if valid API
bsnowden3
pushed a commit
to bsnowden3/bitcore
that referenced
this pull request
Sep 16, 2019
[Feat] Check if valid API
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.