ERC20

[justinkook]

ERC20 changes for BWC/BWS and crypto-wallet-core

Related Copay ERC20 merge request:
https://github.com/bitpay/copay/pull/10162

To install BWC into copay requires:
#2518

Also relies on MR to fix broadcast error: #2520

[warn] ERROR: 500 - "Returned error: Invalid params: invalid type: sequence, expected a 0x-prefixed, hex-encoded vector of bytes."

ERC20 payProV2 proposal:

Changes:

Copay:

1. Fetch ERC20 PayProV2 selectPaymentOptions returns instructions as an array..
2. Create 1 txp with multiple outputs for each instruction:

txp.outputs: [{
    toAddress: '0x..RecievingAddress…',
    amount: 0,
    gasLimit: 21000
}, {
    toAddress: '0x..TokenContractAddress...',
    amount: 0,
    gasLimit: 93028
}]

BWC/BWS:

1. Loop through outputs and create rawTx for each output.

for (const output of txp.outputs) {
    const rawTx = CWC.Transactions.create(…)
}

2. RawTx gets returned as an array of tx hashes

return ['0x12345', '0x98765']

3. Loop through tx array and return array of signatures.

for (const rawTx of txs) {
       const signedTx = CWC.Transaction.applySignatures(...)
}

return ['signature1', 'signature2']
4. Published txp has multiple outputs and property raw as an array of rawTxs instead of a string.
5. POST payProV2 sendSignedTxs with array of signedTxs.

[matiu]

ill review this once ETH BWS is on prod.

[micahriggan]

This is looking pretty good

[matiu]

Great work!

[matiu]

this should be out of the loop. we should store ids = [ txs.map(x=> hash(x))], and id = ids[0],
so all ids get stored on BWS, and also we keep some compatibility with id.

[matiu]

Great job @justinkook and @micahriggan !